You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jonathan Fuchs <jo...@gmail.com> on 2012/05/14 05:31:10 UTC

Review Request: Created a javascript based webui.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5105/
-----------------------------------------------------------

Review request for mesos and Benjamin Hindman.


Summary
-------

uses bootstrap and angular.


Diffs
-----

  src/local/main.cpp 1a91912 
  src/master/http.hpp 1f12b51 
  src/master/http.cpp 7ebcc1b 
  src/master/main.cpp b6329a9 
  src/master/master.hpp e551b1e 
  src/master/master.cpp edbdf5e 
  src/slave/slave.cpp 09a8396 
  src/webui/master/static/angular-1.0.0rc8.js PRE-CREATION 
  src/webui/master/static/app.js PRE-CREATION 
  src/webui/master/static/bootstrap/css/bootstrap-responsive.css PRE-CREATION 
  src/webui/master/static/bootstrap/css/bootstrap.css PRE-CREATION 
  src/webui/master/static/bootstrap/css/docs.css PRE-CREATION 
  src/webui/master/static/bootstrap/ico/favicon.ico PRE-CREATION 
  src/webui/master/static/bootstrap/img/bird.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-01.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-02.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-03.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/browsers.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/github-16px.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons-halflings-white.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons-halflings.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_009_magic.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_042_group.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_079_podium.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_082_roundabout.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_155_show_thumbnails.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_163_iphone.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_214_resize_small.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_266_book_open.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/grid-18px-masked.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-css3.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-github.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-html5.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-twitter.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/less-logo-large.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/less-small.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/responsive-illustrations.png PRE-CREATION 
  src/webui/master/static/bootstrap/js/README.md PRE-CREATION 
  src/webui/master/static/bootstrap/js/application.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-alert.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-button.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-carousel.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-collapse.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-dropdown.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-modal.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-popover.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-scrollspy.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-tab.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-tooltip.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-transition.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-typeahead.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap.min.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/google-code-prettify/prettify.css PRE-CREATION 
  src/webui/master/static/bootstrap/js/google-code-prettify/prettify.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/jquery.js PRE-CREATION 
  src/webui/master/static/controllers.js PRE-CREATION 
  src/webui/master/static/cubism.v1.js PRE-CREATION 
  src/webui/master/static/d3.v2.js PRE-CREATION 
  src/webui/master/static/dashboard.html PRE-CREATION 
  src/webui/master/static/dashboard.js PRE-CREATION 
  src/webui/master/static/framework.html PRE-CREATION 
  src/webui/master/static/frameworks.html PRE-CREATION 
  src/webui/master/static/graph.css PRE-CREATION 
  src/webui/master/static/home.html PRE-CREATION 
  src/webui/master/static/index.html PRE-CREATION 
  src/webui/master/static/log.html PRE-CREATION 
  src/webui/master/static/mesos.css PRE-CREATION 
  src/webui/master/static/slaves.html PRE-CREATION 
  src/webui/master/static/underscore-min.js PRE-CREATION 

Diff: https://reviews.apache.org/r/5105/diff


Testing
-------


Thanks,

Jonathan

Re: Review Request: Created a javascript based webui.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5105/#review7866
-----------------------------------------------------------

Ship it!


- Benjamin


On 2012-05-14 04:49:48, Jonathan Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5105/
> -----------------------------------------------------------
> 
> (Updated 2012-05-14 04:49:48)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Summary
> -------
> 
> uses bootstrap and angular.
> 
> 
> This addresses bug MESOS-193.
>     https://issues.apache.org/jira/browse/MESOS-193
> 
> 
> Diffs
> -----
> 
>   src/local/main.cpp 1a91912 
>   src/master/http.hpp 1f12b51 
>   src/master/http.cpp 7ebcc1b 
>   src/master/main.cpp b6329a9 
>   src/master/master.hpp e551b1e 
>   src/master/master.cpp edbdf5e 
>   src/slave/slave.cpp 09a8396 
>   src/webui/master/static/angular-1.0.0rc8.js PRE-CREATION 
>   src/webui/master/static/app.js PRE-CREATION 
>   src/webui/master/static/bootstrap/css/bootstrap-responsive.css PRE-CREATION 
>   src/webui/master/static/bootstrap/css/bootstrap.css PRE-CREATION 
>   src/webui/master/static/bootstrap/css/docs.css PRE-CREATION 
>   src/webui/master/static/bootstrap/ico/favicon.ico PRE-CREATION 
>   src/webui/master/static/bootstrap/img/bird.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-01.jpg PRE-CREATION 
>   src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-02.jpg PRE-CREATION 
>   src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-03.jpg PRE-CREATION 
>   src/webui/master/static/bootstrap/img/browsers.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/github-16px.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons-halflings-white.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons-halflings.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_009_magic.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_042_group.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_079_podium.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_082_roundabout.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_155_show_thumbnails.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_163_iphone.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_214_resize_small.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/glyphicons/glyphicons_266_book_open.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/grid-18px-masked.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/icon-css3.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/icon-github.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/icon-html5.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/icon-twitter.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/less-logo-large.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/less-small.png PRE-CREATION 
>   src/webui/master/static/bootstrap/img/responsive-illustrations.png PRE-CREATION 
>   src/webui/master/static/bootstrap/js/README.md PRE-CREATION 
>   src/webui/master/static/bootstrap/js/application.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-alert.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-button.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-carousel.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-collapse.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-dropdown.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-modal.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-popover.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-scrollspy.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-tab.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-tooltip.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-transition.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap-typeahead.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/bootstrap.min.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/google-code-prettify/prettify.css PRE-CREATION 
>   src/webui/master/static/bootstrap/js/google-code-prettify/prettify.js PRE-CREATION 
>   src/webui/master/static/bootstrap/js/jquery.js PRE-CREATION 
>   src/webui/master/static/controllers.js PRE-CREATION 
>   src/webui/master/static/cubism.v1.js PRE-CREATION 
>   src/webui/master/static/d3.v2.js PRE-CREATION 
>   src/webui/master/static/dashboard.html PRE-CREATION 
>   src/webui/master/static/dashboard.js PRE-CREATION 
>   src/webui/master/static/framework.html PRE-CREATION 
>   src/webui/master/static/frameworks.html PRE-CREATION 
>   src/webui/master/static/graph.css PRE-CREATION 
>   src/webui/master/static/home.html PRE-CREATION 
>   src/webui/master/static/index.html PRE-CREATION 
>   src/webui/master/static/log.html PRE-CREATION 
>   src/webui/master/static/mesos.css PRE-CREATION 
>   src/webui/master/static/slaves.html PRE-CREATION 
>   src/webui/master/static/underscore-min.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/5105/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan
> 
>

Re: Review Request: Created a javascript based webui.

Posted by Jonathan Fuchs <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5105/
-----------------------------------------------------------

(Updated 2012-05-14 04:49:48.305093)


Review request for mesos and Benjamin Hindman.


Changes
-------

Added bug.


Summary
-------

uses bootstrap and angular.


This addresses bug MESOS-193.
    https://issues.apache.org/jira/browse/MESOS-193


Diffs
-----

  src/local/main.cpp 1a91912 
  src/master/http.hpp 1f12b51 
  src/master/http.cpp 7ebcc1b 
  src/master/main.cpp b6329a9 
  src/master/master.hpp e551b1e 
  src/master/master.cpp edbdf5e 
  src/slave/slave.cpp 09a8396 
  src/webui/master/static/angular-1.0.0rc8.js PRE-CREATION 
  src/webui/master/static/app.js PRE-CREATION 
  src/webui/master/static/bootstrap/css/bootstrap-responsive.css PRE-CREATION 
  src/webui/master/static/bootstrap/css/bootstrap.css PRE-CREATION 
  src/webui/master/static/bootstrap/css/docs.css PRE-CREATION 
  src/webui/master/static/bootstrap/ico/favicon.ico PRE-CREATION 
  src/webui/master/static/bootstrap/img/bird.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-01.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-02.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/bootstrap-mdo-sfmoma-03.jpg PRE-CREATION 
  src/webui/master/static/bootstrap/img/browsers.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/github-16px.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons-halflings-white.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons-halflings.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_009_magic.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_042_group.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_079_podium.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_082_roundabout.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_155_show_thumbnails.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_163_iphone.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_214_resize_small.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/glyphicons/glyphicons_266_book_open.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/grid-18px-masked.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-css3.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-github.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-html5.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/icon-twitter.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/less-logo-large.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/less-small.png PRE-CREATION 
  src/webui/master/static/bootstrap/img/responsive-illustrations.png PRE-CREATION 
  src/webui/master/static/bootstrap/js/README.md PRE-CREATION 
  src/webui/master/static/bootstrap/js/application.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-alert.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-button.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-carousel.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-collapse.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-dropdown.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-modal.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-popover.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-scrollspy.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-tab.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-tooltip.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-transition.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap-typeahead.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/bootstrap.min.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/google-code-prettify/prettify.css PRE-CREATION 
  src/webui/master/static/bootstrap/js/google-code-prettify/prettify.js PRE-CREATION 
  src/webui/master/static/bootstrap/js/jquery.js PRE-CREATION 
  src/webui/master/static/controllers.js PRE-CREATION 
  src/webui/master/static/cubism.v1.js PRE-CREATION 
  src/webui/master/static/d3.v2.js PRE-CREATION 
  src/webui/master/static/dashboard.html PRE-CREATION 
  src/webui/master/static/dashboard.js PRE-CREATION 
  src/webui/master/static/framework.html PRE-CREATION 
  src/webui/master/static/frameworks.html PRE-CREATION 
  src/webui/master/static/graph.css PRE-CREATION 
  src/webui/master/static/home.html PRE-CREATION 
  src/webui/master/static/index.html PRE-CREATION 
  src/webui/master/static/log.html PRE-CREATION 
  src/webui/master/static/mesos.css PRE-CREATION 
  src/webui/master/static/slaves.html PRE-CREATION 
  src/webui/master/static/underscore-min.js PRE-CREATION 

Diff: https://reviews.apache.org/r/5105/diff


Testing
-------


Thanks,

Jonathan