You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/15 17:29:06 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #481: [YUNIKORN-1456] Track dynamic queue priorities
craigcondit opened a new pull request, #481:
URL: https://github.com/apache/yunikorn-core/pull/481
### What is this PR for?
Track dynamic scheduling priority in queue object. This will be used to sort queues for scheduling.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1456
### How should this be tested?
New unit tests added.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #481: [YUNIKORN-1456] Track dynamic queue priorities
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #481: [YUNIKORN-1456] Track dynamic queue priorities
URL: https://github.com/apache/yunikorn-core/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #481: [YUNIKORN-1456] Track dynamic queue priorities
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #481:
URL: https://github.com/apache/yunikorn-core/pull/481#issuecomment-1353469543
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/481?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#481](https://codecov.io/gh/apache/yunikorn-core/pull/481?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6c7c378) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/43e656aabc35ea3e879162244f37a270704ba91b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43e656a) will **increase** coverage by `0.25%`.
> The diff coverage is `94.33%`.
```diff
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 72.77% 73.03% +0.25%
==========================================
Files 69 69
Lines 10207 10338 +131
==========================================
+ Hits 7428 7550 +122
- Misses 2533 2539 +6
- Partials 246 249 +3
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/yunikorn-core/pull/481/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `86.62% <ø> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/481/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `73.64% <89.65%> (+1.27%)` | :arrow_up: |
| [pkg/scheduler/objects/application.go](https://codecov.io/gh/apache/yunikorn-core/pull/481/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `58.30% <100.00%> (+1.51%)` | :arrow_up: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/yunikorn-core/pull/481/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `77.37% <100.00%> (+0.06%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org