You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "jon smit (JIRA)" <de...@tapestry.apache.org> on 2010/02/08 12:10:28 UTC
[jira] Commented: (TAPESTRY-773) Excess code generate for required
parameters
[ https://issues.apache.org/jira/browse/TAPESTRY-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830896#action_12830896 ]
jon smit commented on TAPESTRY-773:
-----------------------------------
It is good sign of intelligence .
jonsmit
=========
<a href="http://www.datecentral.com.au/community/dating-sydney-nsw-f-4.html">Sydney Dating</a>
[url=http://www.datecentral.com.au/community/dating-sydney-nsw-f-4.html]Sydney Dating[/url]
> Excess code generate for required parameters
> --------------------------------------------
>
> Key: TAPESTRY-773
> URL: https://issues.apache.org/jira/browse/TAPESTRY-773
> Project: Tapestry
> Issue Type: Improvement
> Components: Framework
> Affects Versions: 4.0
> Reporter: Howard M. Lewis Ship
> Priority: Minor
> Fix For: 4.1.7
>
>
> When Tapestry is generating code to support component parameters, it generates code such as the following for the setter method:
> public void setRefresh(org.apache.tapestry.IActionListener $1)
> {
> if (! isInActiveState())
> {
> _$refresh$Default = $1;
> return;
> }
> org.apache.tapestry.IBinding binding = getBinding("refresh");
> if (binding == null)
> throw new org.apache.hivemind.ApplicationRuntimeException("Parameter 'refresh' is not bound and can not be updated.");
> binding.setObject(($w) $1);
> if (isRendering())
> {
> _$refresh = $1;
> _$refresh$Cached = true;
> }
> }
> The binding == null check in the middle should be omitted for required parameters, which will always be bound. This will save (a tiny amount of) processing time when generating this code.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.