You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/30 17:24:11 UTC

[jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

This prevents things like CaseFormat changes in downstream providers from affecting how credentials are stored and retrieve. It is also more congruent with how type adapters work.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds adrian.fix-json-serialization

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/595

-- Commit Summary --

  * Use type adapter factory to hard-set serialization of Credentials.

-- File Changes --

    M core/src/main/java/org/jclouds/json/config/GsonModule.java (70)
    M core/src/main/java/org/jclouds/rest/config/CredentialStoreModule.java (40)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/595.patch
https://github.com/jclouds/jclouds/pull/595.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by Adrian Cole <no...@github.com>.

done

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61128661

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by Adrian Cole <no...@github.com>.

cc @andreaturli @nacx 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61121754

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #1367](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1367/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61126046

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by Andrea Turli <no...@github.com>.

:+1: please merge it and backport it to 1.8.x as well as I want to test it there as well. Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61126964

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by Ignasi Barrera <no...@github.com>.

+1, thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61127888

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests-java-7 #278](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/278/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61124915

Re: [jclouds] Use type adapter factory to hard-set serialization of Credentials. (#595)

Posted by BuildHive <no...@github.com>.

[jclouds » jclouds #1890](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1890/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/595#issuecomment-61131520