You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@steve.apache.org by "Ray Ma (Jira)" <ji...@apache.org> on 2019/09/25 01:29:00 UTC
[jira] [Created] (STEVE-55) Improve consistency in config reading
Ray Ma created STEVE-55:
---------------------------
Summary: Improve consistency in config reading
Key: STEVE-55
URL: https://issues.apache.org/jira/browse/STEVE-55
Project: Steve
Issue Type: Improvement
Reporter: Ray Ma
In pysteve/lib/backends/es.py, there are two places where it reads the config['elasticsearch']['index'] (pseudo code), but in one the value was a conditional, where if the config didn't have the index option, it would have 'steve' as a default, but in the other place would throw a NoOptionError if the option didn't exist.
Just for consistency's sake, it might be good if we either hard-require this (i.e. throw at any place when option's not here), or use 'steve' as a default (i.e. either using conditionals or a default value in steve.cfg).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)