[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9505: [Refactor] Use file factory to replace create file reader/writer

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9505:
URL: https://github.com/apache/incubator-doris/pull/9505#discussion_r870157017


##########
be/src/exec/CMakeLists.txt:
##########
@@ -92,25 +90,29 @@ set(EXEC_FILES
     partitioned_hash_table.cc
     partitioned_aggregation_node.cc
     odbc_scan_node.cpp
-    local_file_writer.cpp
-    broker_writer.cpp
     parquet_scanner.cpp
     parquet_reader.cpp
     parquet_writer.cpp
     orc_scanner.cpp
     odbc_connector.cpp
     json_scanner.cpp
     assert_num_rows_node.cpp
-    s3_reader.cpp
-    s3_writer.cpp
-    hdfs_reader_writer.cpp
+
+    file/local_file_reader.cpp
+    file/local_file_writer.cpp
+    file/broker_reader.cpp
+    file/broker_writer.cpp
+    file/s3_reader.cpp
+    file/s3_writer.cpp
+    file/hdfs_reader_writer.cpp

Review Comment:
   Why not split to hdfs_reader.cpp and hdfs_writer.cpp as local, s3, broker ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org