[GitHub] [airflow] ashb commented on a change in pull request #22134: Add vertical scrolling to grid view

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #22134:
URL: https://github.com/apache/airflow/pull/22134#discussion_r824112769



##########
File path: airflow/www/static/js/tree/renderTaskRows.jsx
##########
@@ -160,7 +172,7 @@ const Row = (props) => {
           </Collapse>
         </Td>
         <Td width={0} p={0} borderBottom={0} />
-        <Td p={0} align="right" _groupHover={{ backgroundColor: 'rgba(113, 128, 150, 0.1)' }} transition="background-color 0.2s" borderBottom={0}>
+        <Td p={0} align="right" _groupHover={{ backgroundColor: 'rgba(113, 128, 150, 0.1)' }} transition="background-color 0.2s" borderBottom={0} width={`${dagRunIds.length * 16}px`}>

Review comment:
       Where does the 16px per dagRun come from? Is there anyway to not have this hardcoded here but somehow worked out based on what the Column tells us?
   
   Secondly we have this in `16px` two places.
   
   Thirdly: on L111 we have 18px wide box for empty TI -- shouldn't that be the same width? (Not 100% sure)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org