You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2019/01/22 02:31:53 UTC

[GitHub] [incubator-dubbo] codecov-io commented on issue #3297: code optimization

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=h1) Report
> Merging [#3297](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/0a2b9bfe7c390529f3f39228879ac848e154e813?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `69.76%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3297      +/-   ##
============================================
- Coverage     63.97%   63.91%   -0.07%     
  Complexity       75       75              
============================================
  Files           654      654              
  Lines         28236    28230       -6     
  Branches       4780     4779       -1     
============================================
- Hits          18064    18043      -21     
- Misses         7981     7994      +13     
- Partials       2191     2193       +2
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...rg/apache/dubbo/rpc/proxy/jdk/JdkProxyFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9qZGsvSmRrUHJveHlGYWN0b3J5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `92.85% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/java/org/apache/dubbo/common/bytecode/Proxy.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vYnl0ZWNvZGUvUHJveHkuamF2YQ==) | `70.76% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/dubbo/rpc/protocol/dubbo/filter/TraceFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL2ZpbHRlci9UcmFjZUZpbHRlci5qYXZh) | `12.5% <25%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0RlY29kZWFibGVScGNSZXN1bHQuamF2YQ==) | `69.64% <66.66%> (+18.08%)` | `0 <0> (ø)` | :arrow_down: |
| [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `58.82% <75%> (+0.49%)` | `0 <0> (ø)` | :arrow_down: |
| [...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0R1YmJvUHJvdG9jb2wuamF2YQ==) | `66.8% <92.3%> (+0.13%)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | `0% <0%> (ø)` | |
| [...che/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L21pbmEvTWluYUNoYW5uZWwuamF2YQ==) | `43.42% <0%> (-10.53%)` | `0% <0%> (ø)` | |
| ... and [12 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3297/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=footer). Last update [0a2b9bf...9a494a5](https://codecov.io/gh/apache/incubator-dubbo/pull/3297?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3297 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org