You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/03/06 12:06:23 UTC

[GitHub] rabbah commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

rabbah commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110
URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r172493830
 
 

 ##########
 File path: core/invoker/src/main/resources/application.conf
 ##########
 @@ -39,7 +49,6 @@ whisk {
   container-factory.container-args {
     network: bridge
     dns-servers: []
-    extra-args: {}
-
+    extra-args: {}   # to pass additional args to 'docker run'; format is `{key1: [v1, v2], key2: [v1, v2]`
 
 Review comment:
   closing `}` missing in comment; does the value have to be an array?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services