[GitHub] mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity with null

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4908: Replace NaN/Infinity with null
URL: https://github.com/apache/incubator-superset/pull/4908#discussion_r185031456
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2435,7 +2436,7 @@ def sql_json(self):
 
             resp = json_success(json.dumps(
                 {'query': query.to_dict()}, default=utils.json_int_dttm_ser,
-                allow_nan=False), status=202)
+                ignore_nan=True), status=202)
 
 Review comment:
   This is a little bit scary as it was set to False explicitly in the past, probably for a reason. I'm guessing the default is `True` and someone set it to `False` for some specific reason. We should do a bit of git forensics to understand how it came to be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services