You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/09/02 23:09:52 UTC

Re: Review Request 61306: Enabled building Java artifacts with CMake.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61306/#review184446
-----------------------------------------------------------


Fix it, then Ship it!




I'll fixup before committing.


cmake/CompilationConfigure.cmake
Lines 38-39 (patched)
<https://reviews.apache.org/r/61306/#comment260609>

    This should be checking `NOT JNI_FOUND`


- Joseph Wu


On Aug. 8, 2017, 5:56 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61306/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2017, 5:56 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-7835
>     https://issues.apache.org/jira/browse/MESOS-7835
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/61306
> 
> 
> Diffs
> -----
> 
>   cmake/CompilationConfigure.cmake 2109697e02e58c673948f2ae67ef8255d16aa736 
>   cmake/MesosConfigure.cmake 5ecad2c0fbd245dd14e9c09869dd6da2ca4e602a 
>   src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c 
>   src/tests/CMakeLists.txt 6dd2716de942adf6cefa5a464ef664f3c3ebb7a3 
> 
> 
> Diff: https://reviews.apache.org/r/61306/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>