You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Marc Slemko <ma...@znep.com> on 1997/09/07 20:14:52 UTC
[PATCH] fix proxy dependencies
I don't like the proxy rebuilding its library every time you do anything.
So I stopped it from doing that. Is there any reason why it is doing
this?
I don't like it not rebuilding if you run Configure without a make clean,
so I added a dependency to deal with it.
Index: Makefile
===================================================================
RCS file: /export/home/cvs/apachen/src/modules/proxy/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- Makefile 1997/08/23 22:23:11 1.15
+++ Makefile 1997/09/07 18:09:47
@@ -66,14 +66,11 @@
OBJS=$(PROXYSRC:.c=.o)
-default: force $(LIB)
+default: $(LIB)
.c.a:
$(MAKE) $(CFLAGS) $<
-force:
- rm -f $(LIB)
-
$(LIB): $(OBJS)
ar crv $@ $(OBJS)
$(RANLIB) $@
@@ -82,7 +79,7 @@
rm -f *.o libproxy.a
# dependencies
-$(OBJS): mod_proxy.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h $(INCDIR)/http_protocol.h
+$(OBJS): mod_proxy.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h $(INCDIR)/http_protocol.h ../../Makefile
proxy_cache.o proxy_connect.o proxy_http.o proxy_util.o: $(INCDIR)/http_main.h
proxy_cache.o proxy_connect.o proxy_http.o: $(INCDIR)/http_log.h
proxy_cache.o proxy_http.o: $(INCDIR)/util_date.h
Re: [PATCH] fix proxy dependencies
Posted by Chuck Murcko <ch...@topsail.org>.
It used to force a rebuild of the .a to pick up any source changes in
the make. I guess that's been changed. It used to rebuild just fine when
Apache was reconfigured. The worst it would do was relink the .a.
Marc Slemko wrote:
>
> I don't like the proxy rebuilding its library every time you do anything.
> So I stopped it from doing that. Is there any reason why it is doing
> this?
>
> I don't like it not rebuilding if you run Configure without a make clean,
> so I added a dependency to deal with it.
>
> Index: Makefile
> ===================================================================
> RCS file: /export/home/cvs/apachen/src/modules/proxy/Makefile,v
> retrieving revision 1.15
> diff -u -r1.15 Makefile
> --- Makefile 1997/08/23 22:23:11 1.15
> +++ Makefile 1997/09/07 18:09:47
> @@ -66,14 +66,11 @@
>
> OBJS=$(PROXYSRC:.c=.o)
>
> -default: force $(LIB)
> +default: $(LIB)
>
> .c.a:
> $(MAKE) $(CFLAGS) $<
>
> -force:
> - rm -f $(LIB)
> -
> $(LIB): $(OBJS)
> ar crv $@ $(OBJS)
> $(RANLIB) $@
> @@ -82,7 +79,7 @@
> rm -f *.o libproxy.a
>
> # dependencies
> -$(OBJS): mod_proxy.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h $(INCDIR)/http_protocol.h
> +$(OBJS): mod_proxy.h $(INCDIR)/httpd.h $(INCDIR)/http_config.h $(INCDIR)/http_protocol.h ../../Makefile
> proxy_cache.o proxy_connect.o proxy_http.o proxy_util.o: $(INCDIR)/http_main.h
> proxy_cache.o proxy_connect.o proxy_http.o: $(INCDIR)/http_log.h
> proxy_cache.o proxy_http.o: $(INCDIR)/util_date.h
--
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org
Re: [PATCH] fix proxy dependencies
Posted by Chuck Murcko <ch...@topsail.org>.
Marc Slemko wrote:
>
> On Mon, 8 Sep 1997, Chuck Murcko wrote:
>
> > Marc Slemko wrote:
> > >
> > > It doesn't clean itself, but it does a rm -f libproxy.a and rebuilds it.
> > > So it cleans the library. It has been like that for a good while... it
> > > appears like forever.
> > >
> > Oh, OK. Yes, that is the design behavior. When two subdirectories down
> > from the main Makefile, I found that forcing a re-ar of the lib was the
> > only way to pick up source changes to the .[ch] files. However, if the
> > Makefile is now auto-generated, then it would be easier to get around
> > this.
> >
> > The side effect of removing the force will be that you have to make
> > clean every time the source changes.
>
> Nope; I checked that out and it seems to be built fine when source
> changes.
OK, then. Might as well leave it that way. The force target was
suggested by the O'Reilly Make book, so I'm wondering if the problem is
just some old makes. We'll see.
--
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org
Re: [PATCH] fix proxy dependencies
Posted by Marc Slemko <ma...@worldgate.com>.
On Mon, 8 Sep 1997, Chuck Murcko wrote:
> Marc Slemko wrote:
> >
> > It doesn't clean itself, but it does a rm -f libproxy.a and rebuilds it.
> > So it cleans the library. It has been like that for a good while... it
> > appears like forever.
> >
> Oh, OK. Yes, that is the design behavior. When two subdirectories down
> from the main Makefile, I found that forcing a re-ar of the lib was the
> only way to pick up source changes to the .[ch] files. However, if the
> Makefile is now auto-generated, then it would be easier to get around
> this.
>
> The side effect of removing the force will be that you have to make
> clean every time the source changes.
Nope; I checked that out and it seems to be built fine when source
changes.
Re: [PATCH] fix proxy dependencies
Posted by Chuck Murcko <ch...@topsail.org>.
Marc Slemko wrote:
>
> It doesn't clean itself, but it does a rm -f libproxy.a and rebuilds it.
> So it cleans the library. It has been like that for a good while... it
> appears like forever.
>
Oh, OK. Yes, that is the design behavior. When two subdirectories down
from the main Makefile, I found that forcing a re-ar of the lib was the
only way to pick up source changes to the .[ch] files. However, if the
Makefile is now auto-generated, then it would be easier to get around
this.
The side effect of removing the force will be that you have to make
clean every time the source changes.
--
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org
Re: [PATCH] fix proxy dependencies
Posted by Marc Slemko <ma...@worldgate.com>.
It doesn't clean itself, but it does a rm -f libproxy.a and rebuilds it.
So it cleans the library. It has been like that for a good while... it
appears like forever.
On Mon, 8 Sep 1997, Chuck Murcko wrote:
> Paul Sutton wrote:
> >
> > On Sun, 7 Sep 1997, Marc Slemko wrote:
> > > I don't like the proxy rebuilding its library every time you do anything.
> > > So I stopped it from doing that. Is there any reason why it is doing
> > > this?
> >
> > I dunno. But no other sub-dirs clean themselves on every make and no-one's
> > reported a problem so far...
> >
> It *cleans* itself on every make? When did that get broken? Definitely
> after 1.2.0.
> --
> chuck
> Chuck Murcko
> The Topsail Group, West Chester PA USA
> chuck@topsail.org
>
Re: [PATCH] fix proxy dependencies
Posted by Chuck Murcko <ch...@topsail.org>.
Paul Sutton wrote:
>
> On Sun, 7 Sep 1997, Marc Slemko wrote:
> > I don't like the proxy rebuilding its library every time you do anything.
> > So I stopped it from doing that. Is there any reason why it is doing
> > this?
>
> I dunno. But no other sub-dirs clean themselves on every make and no-one's
> reported a problem so far...
>
It *cleans* itself on every make? When did that get broken? Definitely
after 1.2.0.
--
chuck
Chuck Murcko
The Topsail Group, West Chester PA USA
chuck@topsail.org
Re: [PATCH] fix proxy dependencies
Posted by Paul Sutton <pa...@ukweb.com>.
On Sun, 7 Sep 1997, Marc Slemko wrote:
> I don't like the proxy rebuilding its library every time you do anything.
> So I stopped it from doing that. Is there any reason why it is doing
> this?
I dunno. But no other sub-dirs clean themselves on every make and no-one's
reported a problem so far...
> I don't like it not rebuilding if you run Configure without a make clean,
> so I added a dependency to deal with it.
+1 to this patch. Although we could simplify it even more by moving it to
Makefile.tmpl and getting Configure to auto-create the Makefile. Then we
only have to make changes in one place (Configure) to affect the build of
all module dirs.
//pcs