(tooling-agents) branch main updated: ASVS audit: 11.6.2.md (redacted)

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

asf-tooling pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tooling-agents.git


The following commit(s) were added to refs/heads/main by this push:
     new 26ec852  ASVS audit: 11.6.2.md (redacted)
26ec852 is described below

commit 26ec852cb7a0ef1906e7d0a10a0ef76e0d81a80a
Author: ASF Tooling Team <ro...@apache.org>
AuthorDate: Tue May 5 14:02:39 2026 +0200

    ASVS audit: 11.6.2.md (redacted)
---
 ASVS/reports/steve/v3/d0aa7e9/all/11.6.2.md | 78 +++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

diff --git a/ASVS/reports/steve/v3/d0aa7e9/all/11.6.2.md b/ASVS/reports/steve/v3/d0aa7e9/all/11.6.2.md
new file mode 100644
index 0000000..d74da39
--- /dev/null
+++ b/ASVS/reports/steve/v3/d0aa7e9/all/11.6.2.md
@@ -0,0 +1,78 @@
+# Security Audit Report: ASVS 11.6.2
+
+## Executive Summary
+
+| Field | Value |
+|-------|-------|
+| **Repository** | apache/steve/v3 |
+| **Audit Date** | May 05, 2026 |
+| **Auditor** | Tooling Agents (bundled-pass mode) |
+| **ASVS Requirement** | ASVS 11.6.2 |
+| **Files Analyzed** | 8 relevant / 49 total |
+| **Files Skipped** | 12 |
+
+**Requirement description:** Verify that approved cryptographic algorithms are used for key exchange (such as Diffie-Hellman) with a focus on ensuring that key exchange mechanisms use secure parameters. This will prevent attacks on the key establishment process which could lead to adversary-in-the-middle attacks or…
+
+### Findings Overview
+
+| Severity | Count |
+|----------|-------|
+| 🔴 Critical | 0 |
+| 🟠 High | 0 |
+| 🟡 Medium | 0 |
+| 🟢 Low | 0 |
+
+---
+
+## ASVS-11.6.2: Approved Key Exchange Algorithms with Secure Parameters
+
+### Findings for 11.6.2
+
+No findings detected. No key exchange mechanisms (Diffie-Hellman, ECDH, etc.) are implemented in this codebase. The system uses symmetric encryption with keys derived from salts and election data rather than interactive key exchange protocols.
+
+### Security Controls Inventory for 11.6.2
+
+No applicable controls in this scope. The system's cryptographic architecture relies on:
+- Server-side key derivation (HKDF from vote tokens)
+- Salt-based key material (generated server-side)
+- No peer-to-peer key exchange
+
+TLS configuration for transport security is outside the scope of this source code audit.
+
+### Positive Patterns for 11.6.2
+
+1. **Key material never exchanged**: The system derives encryption keys server-side from deterministic inputs (opened_key + pid + iid + salt), eliminating the need for key exchange protocols and their associated attack surface.
+
+---
+
+
+
+## Cross-cutting Architecture Observations
+
+1. **Cryptographic Design is Sound**: The overall cryptographic architecture (salt generation → Argon2 key derivation → HKDF key stretching → Fernet encryption) follows a well-structured layered approach with proper separation of concerns.
+
+2. **ID Entropy vs. Authorization**: The low entropy in `create_id()` (40 bits) is partially mitigated by the incomplete but intended authorization layer. However, since authz is currently placeholder (`### check authz`), the low-entropy IDs are the *only* barrier to unauthorized access, making the entropy issue more critical in practice.
+
+3. **Consistent Use of CSPRNG**: The codebase consistently uses `secrets` for security-sensitive randomness, with only the candidate display shuffle using `random` (acceptable for non-security display ordering).
+
+4. **Anti-Tamper Mechanism**: The `opened_key` / `is_tampered()` design provides integrity verification for elections, but its effectiveness depends on the security of the underlying Argon2 derivation.
+
+5. **Encryption Transition Planning**: The comments indicate a planned migration from Fernet (AES-128-CBC + HMAC-SHA256) to XChaCha20-Poly1305, which would be an improvement in terms of modern algorithm selection and nonce management.
+
+## Cross-cutting Recommendations
+
+### Immediate (Critical)
+1. **Increase ID entropy to 128 bits**: Change `create_id()` to use `secrets.token_hex(16)` and update the database schema constraints. This is essential given the absence of proper authorization checks.
+
+### Short-term (High)
+2. **Switch from Argon2d to Argon2id**: Change `type=argon2.low_level.Type.D` to `type=argon2.low_level.Type.ID` in the `_hash()` function. This is a one-line change that improves resistance to side-channel attacks per RFC 9106 recommendations.
+
+3. **Implement authorization checks**: The multiple `### check authz` placeholders create false confidence — the decorator-based auth ensures authentication but not authorization (ownership/permission checks).
+
+### Long-term (Medium)
+4. **Memory protection for sensitive operations**: Consider using `mlock()` for memory pages containing decrypted votes during tally operations, and implement explicit memory clearing patterns.
+
+5. **Incremental hashing in `gather_election_data()`**: Refactor to use streaming hash computation instead of accumulating all voter data in memory.
+
+6. **Complete the Fernet → XChaCha20-Poly1305 migration**: As noted in the code comments, this transition would bring the system to a more modern AEAD construction with larger nonce space.
+        
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org