You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2022/01/16 21:23:26 UTC
[GitHub] [guacamole-client] nw-engineer opened a new pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.
nw-engineer opened a new pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684
Fixed so that full-width and half-width keys work correctly and Japanese input switching works.
Hope to include it in the next release. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] nw-engineer commented on pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.
Posted by GitBox <gi...@apache.org>.
nw-engineer commented on pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684#issuecomment-1014981790
I'm really sorry. I wasn't able to see the exchanges of past issues.（GUACAMOLE-520,GUACAMOLE-951)
Also, some change requests are mistaken.
I would like to confirm the contents again and send a separate pull request.
I canceled this pull est
What should I do now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] nw-engineer closed pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.
Posted by GitBox <gi...@apache.org>.
nw-engineer closed pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] nw-engineer commented on pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.
Posted by GitBox <gi...@apache.org>.
nw-engineer commented on pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684#issuecomment-1017180856
I didn't comment in particular, so I will close it. I apologize to you for a fuss over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #684: GUACAMOLE-1503: Japanese Character input cannot be switched By full-width half-width key.
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #684:
URL: https://github.com/apache/guacamole-client/pull/684#discussion_r786324227
##########
File path: guacamole-common-js/src/main/webapp/modules/InputSink.js
##########
@@ -118,11 +118,11 @@ Guacamole.InputSink = function InputSink() {
var rect = focused.getBoundingClientRect();
if (rect.left + rect.width > 0 && rect.top + rect.height > 0)
return;
+ sink.focus();
}
// Refocus input sink instead of handling click
- sink.focus();
Review comment:
What's the reasoning behind this change?
##########
File path: guacamole-common-js/src/main/webapp/modules/Keyboard.js
##########
@@ -559,8 +561,7 @@ Guacamole.Keyboard = function Keyboard(element) {
"Up": [0xFF52],
"Undo": [0xFF65],
"Win": [0xFFE7, 0xFFE7, 0xFFE8],
- "Zenkaku": [0xFF28],
- "ZenkakuHankaku": [0xFF2A]
+ "Zenkaku": [0xFF28]
Review comment:
Why is the definition for `ZenkakuHankaku` being removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org