You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/08/20 17:41:38 UTC
[GitHub] [struts-examples] fp024 opened a new pull request, #164: Add JasperReports tutorial example
fp024 opened a new pull request, #164:
URL: https://github.com/apache/struts-examples/pull/164
hello.
Because there is no JasperReport tutorial example on struts-example github,
I made an example project by looking at the jasper-reports-tutorial document.
please review.
thank you.
* https://struts.apache.org/getting-started/jasper-reports-tutorial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
fp024 commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950865890
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
If there are no major problems with the merged content, I will not make a new "Pull Request". 😄
I've only practiced in my personal Github repository.
* JasperReports example project with Spring
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-struts
* JasperReports example project without Spring - using Servlet's ContextListener
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-with-contextlistener
* JasperReports example project without Spring - using Interceptor
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-with-interceptor
So have a nice day. 😄
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
fp024 commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950865890
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
If there are no major problems with the merged content, I will not make a new "Pull Request". 😄
I've only practiced in my personal Github repository.
* JasperReports example project with Spring
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-struts
* JasperReports example project without Spring - using Servlet's ContextListener
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-with-contextlistener
* JasperReports example project without Spring - using Interceptor
* https://github.com/fp024/struts2-study/tree/master/jasper-reports-tutorial/jasper-reports-with-interceptor
So have a nice day. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] lukaszlenart commented on pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on PR #164:
URL: https://github.com/apache/struts-examples/pull/164#issuecomment-1221513702
Nice :) LGTM 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] yasserzamani commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950833728
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
> Sorry @yasserzamani I was too rush :)
No problem, the sample is already a nice jasperreport with spring sample :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] yasserzamani commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950819926
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
Firstly thank you very much for your PR!
Just IMHO add spring as dependency is too much for this sample I think. If you want then you might delete all spring stuff from your sample. Instead, in the beginning of action method, simply check if corresponding .jasper file exists or not. If exists then do nothing otherwise compile the .jrxml file and create the needed .jasper file.
This approach will have two benefits:
1. User can update and deploy a new report design without restarting app i.e. by deleting .jasper and .jrxml files and copying new .jrxml file.
2. The sample will be less complex and also will have less not required dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] fp024 commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
fp024 commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950825337
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
Thanks for the code review.
I will edit the code again soon and submit a Pull Request again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] lukaszlenart merged pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged PR #164:
URL: https://github.com/apache/struts-examples/pull/164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] yasserzamani commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
yasserzamani commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r952303292
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
@fp024 no thank you, there's no major issue :) specially now that you've removed Spring bom. thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts-examples] lukaszlenart commented on a diff in pull request #164: Add JasperReports tutorial example
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on code in PR #164:
URL: https://github.com/apache/struts-examples/pull/164#discussion_r950820154
##########
jasperreports/pom.xml:
##########
@@ -0,0 +1,87 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
+ http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+ <parent>
+ <artifactId>struts-examples</artifactId>
+ <groupId>org.apache.struts</groupId>
+ <version>1.1.0</version>
+ </parent>
+
+ <artifactId>jasperreports</artifactId>
+ <packaging>war</packaging>
+
+ <name>JasperReports Tutorial</name>
+ <url>https://struts.apache.org/getting-started/jasper-reports-tutorial</url>
+ <properties>
+ <spring.platformVersion>5.3.20</spring.platformVersion>
+ <jasperreports.version>6.20.0</jasperreports.version>
+ </properties>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-framework-bom</artifactId>
Review Comment:
Sorry @yasserzamani I was too rush :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org