You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "huwh (via GitHub)" <gi...@apache.org> on 2023/09/13 05:08:22 UTC
[GitHub] [flink] huwh commented on a diff in pull request #23399: [FLINK-33061][docs] Translate failure-enricher documentation to Chinese
huwh commented on code in PR #23399:
URL: https://github.com/apache/flink/pull/23399#discussion_r1323974700
##########
docs/content/docs/deployment/advanced/failure_enrichers.md:
##########
@@ -42,7 +42,7 @@ To implement a custom FailureEnricher plugin, you need to:
Then, create a jar which includes your `FailureEnricher`, `FailureEnricherFactory`, `META-INF/services/` and all external dependencies.
Make a directory in `plugins/` of your Flink distribution with an arbitrary name, e.g. "failure-enrichment", and put the jar into this directory.
-See [Flink Plugin]({% link deployment/filesystems/plugins.md %}) for more details.
+See [Flink Plugin]({{< ref "docs/deployment/filesystems/plugins" >}}) for more details.
Review Comment:
I haven’t reviewed it in detail yet. Can you separate this fix change into an independent commit? This is unrelated to translation work.
##########
docs/content/docs/deployment/advanced/failure_enrichers.md:
##########
@@ -42,7 +42,7 @@ To implement a custom FailureEnricher plugin, you need to:
Then, create a jar which includes your `FailureEnricher`, `FailureEnricherFactory`, `META-INF/services/` and all external dependencies.
Make a directory in `plugins/` of your Flink distribution with an arbitrary name, e.g. "failure-enrichment", and put the jar into this directory.
-See [Flink Plugin]({% link deployment/filesystems/plugins.md %}) for more details.
+See [Flink Plugin]({{< ref "docs/deployment/filesystems/plugins" >}}) for more details.
Review Comment:
I haven’t reviewed it in detail yet. Can you separate this fix change into an independent commit? This is unrelated to translation work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org