[jira] [Commented] (IGNITE-13306) CpuLoad metric return -1 under Java 11

["Stanislav Lukyanov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-13306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171481#comment-17171481 ] 

Stanislav Lukyanov commented on IGNITE-13306:
---------------------------------------------

The correct fix would be to change
{code}
            boolean accessible = m.isAccessible();

            try {
                m.setAccessible(true);

                return (T)m.invoke(obj);
            }
            finally {
                m.setAccessible(accessible);
            }
{code}
to
{code}
            try {
                return (T)m.invoke(obj);
            } catch (IllegalAccessException e) {
                try {
                    m.setAccessible(true);

                    return (T)m.invoke(obj);
                }
                finally {
                    m.setAccessible(accessible);
                }
            }
{code}
in IgniteUtils.

In Java 9 JPMS will not allow you to call setAccessible unless the module opens itself to your module. However, in this case we don't even need setAccessible because the getter we use is public.

> CpuLoad metric return -1 under Java 11
> --------------------------------------
>
>                 Key: IGNITE-13306
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13306
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.8.1
>            Reporter: Mirza Aliev
>            Assignee: Mirza Aliev
>            Priority: Major
>             Fix For: 2.9
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Start cluster under Java 11.
> Observed: 
>  CpuLoad metric will return -1
> Expected:
>  Real CpuLoad.
> We investigated this issue and found that under Java 11 code failed with following trace:
> {code:java}
> class org.apache.ignite.IgniteException: Failed to get property value [property=processCpuTime, obj=com.sun.management.internal.OperatingSystemImpl@1dd92fe2] at org.apache.ignite.internal.util.IgniteUtils.property(IgniteUtils.java:8306) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$MetricsUpdater.getCpuLoad(GridDiscoveryManager.java:3131) at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$MetricsUpdater.run(GridDiscoveryManager.java:3093) at org.apache.ignite.internal.processors.timeout.GridTimeoutProcessor$CancelableTask.onTimeout(GridTimeoutProcessor.java:364) at org.apache.ignite.internal.processors.timeout.GridTimeoutProcessor$TimeoutWorker.body(GridTimeoutProcessor.java:233) at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:119) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make public long com.sun.management.internal.OperatingSystemImpl.getProcessCpuTime() accessible: module jdk.management does not "opens com.sun.management.internal" to unnamed module @35fb3008 at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:340) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:280) at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:198) at java.base/java.lang.reflect.Method.setAccessible(Method.java:192) at org.apache.ignite.internal.util.IgniteUtils.property(IgniteUtils.java:8297) ... 6 more
> {code}
> Under Java 8 metric has expected value.
>  
> Solution:
> The behaviour is expected because in Java 11 the CPU load metrics is moved to JDK internal module which is not accessible by default. Adding the following line to the jvm in which Ignite node is started should solve the issue:
> {noformat}
> --add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)