You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sg...@apache.org on 2014/12/18 09:02:28 UTC
[1/7] cordova-wp8 git commit: remove destructor trace
Repository: cordova-wp8
Updated Branches:
refs/heads/3.7.x 279215372 -> f57cca727
remove destructor trace
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/993716cf
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/993716cf
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/993716cf
Branch: refs/heads/3.7.x
Commit: 993716cf46d5e83dfa68013106a341d1ebb41a92
Parents: 29bf885
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Tue Dec 16 00:04:37 2014 -0800
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 10:58:26 2014 +0300
----------------------------------------------------------------------
template/cordovalib/CordovaView.xaml.cs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/993716cf/template/cordovalib/CordovaView.xaml.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/CordovaView.xaml.cs b/template/cordovalib/CordovaView.xaml.cs
index df91d73..9a22d0f 100644
--- a/template/cordovalib/CordovaView.xaml.cs
+++ b/template/cordovalib/CordovaView.xaml.cs
@@ -574,7 +574,7 @@ namespace WPCordovaClassLib
~CordovaView()
{
- Debug.WriteLine("CordovaView is destroyed");
+ //Debug.WriteLine("CordovaView is destroyed");
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[7/7] cordova-wp8 git commit: Set VERSION to 3.7.1 (via coho)
Posted by sg...@apache.org.
Set VERSION to 3.7.1 (via coho)
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/f57cca72
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/f57cca72
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/f57cca72
Branch: refs/heads/3.7.x
Commit: f57cca727650e12154d150587a3b3bac52b8352b
Parents: 825be41
Author: sgrebnov <v-...@microsoft.com>
Authored: Thu Dec 18 11:00:41 2014 +0300
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 11:00:41 2014 +0300
----------------------------------------------------------------------
VERSION | 2 +-
package.json | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/f57cca72/VERSION
----------------------------------------------------------------------
diff --git a/VERSION b/VERSION
index 7c69a55..a76ccff 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-3.7.0
+3.7.1
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/f57cca72/package.json
----------------------------------------------------------------------
diff --git a/package.json b/package.json
index 72e42e2..21959bf 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
{
"name": "cordova-wp8",
- "version": "3.7.0",
+ "version": "3.7.1",
"description": "cordova-wp8 v3.7.0-dev",
"main": "bin/create",
"repository": {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[5/7] cordova-wp8 git commit: CB-8139 WP8. Fix callback for plugins
with native ui (capture, contactPicker, BarcodeScanner, other)
Posted by sg...@apache.org.
CB-8139 WP8. Fix callback for plugins with native ui (capture, contactPicker, BarcodeScanner, other)
Unload event could not be used to detect when CordovaView is not used anymore. For example, this event is triggered when we execute command that shows some native elements on new page and then we return back. In this case Unloaded event is called but, but control state is preserved and we should continue to use that Cordova view instance.
This commit changes the following:
1. Allows command instances to be garbage collected => fixes corresponding memory leak so that NativeExecution is no more required to call DetachHandlers for each command. This fixes CB-8139.
2. Use Loaded and Unloaded events to add/remove handlers for native events; this makes it possible for GC to destroy CordovaView when it is not required anymore
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/cca4d44a
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/cca4d44a
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/cca4d44a
Branch: refs/heads/3.7.x
Commit: cca4d44a8c8984c98dc976d0e529ad4f336f0716
Parents: 2a40405
Author: sgrebnov <v-...@microsoft.com>
Authored: Mon Dec 15 17:52:27 2014 +0300
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 10:58:26 2014 +0300
----------------------------------------------------------------------
template/cordovalib/ConsoleHelper.cs | 26 ++++------
template/cordovalib/CordovaView.xaml.cs | 70 ++++++++++++++-------------
template/cordovalib/IBrowserDecorator.cs | 2 +
template/cordovalib/NativeExecution.cs | 27 +++--------
template/cordovalib/OrientationHelper.cs | 10 ++++
template/cordovalib/XHRHelper.cs | 10 ++++
6 files changed, 75 insertions(+), 70 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/ConsoleHelper.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/ConsoleHelper.cs b/template/cordovalib/ConsoleHelper.cs
index 3443821..72edfb2 100644
--- a/template/cordovalib/ConsoleHelper.cs
+++ b/template/cordovalib/ConsoleHelper.cs
@@ -38,13 +38,6 @@ namespace WPCordovaClassLib.CordovaLib
{
}
- if (!hasListener)
- {
- PhoneApplicationService.Current.Closing += OnServiceClosing;
- hasListener = true;
- }
-
-
string script = @"(function(win) {
function exec(msg) { window.external.Notify('ConsoleLog/' + msg); }
var cons = win.console = win.console || {};
@@ -71,15 +64,6 @@ namespace WPCordovaClassLib.CordovaLib
}
}
- public void DetachHandler()
- {
- if (hasListener)
- {
- PhoneApplicationService.Current.Closing -= OnServiceClosing;
- hasListener = false;
- }
- }
-
public bool HandleCommand(string commandStr)
{
string output = commandStr.Substring("ConsoleLog/".Length);
@@ -96,5 +80,15 @@ namespace WPCordovaClassLib.CordovaLib
return true;
}
+ public void AttachNativeHandlers()
+ {
+ PhoneApplicationService.Current.Closing += OnServiceClosing;
+ }
+
+ public void DetachNativeHandlers()
+ {
+ PhoneApplicationService.Current.Closing -= OnServiceClosing;
+ }
+
}
}
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/CordovaView.xaml.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/CordovaView.xaml.cs b/template/cordovalib/CordovaView.xaml.cs
index 5e790a3..4c509e0 100644
--- a/template/cordovalib/CordovaView.xaml.cs
+++ b/template/cordovalib/CordovaView.xaml.cs
@@ -136,21 +136,7 @@ namespace WPCordovaClassLib
return;
}
-
- StartupMode mode = PhoneApplicationService.Current.StartupMode;
-
- if (mode == StartupMode.Launch)
- {
- PhoneApplicationService service = PhoneApplicationService.Current;
- service.Activated += new EventHandler<Microsoft.Phone.Shell.ActivatedEventArgs>(AppActivated);
- service.Launching += new EventHandler<LaunchingEventArgs>(AppLaunching);
- service.Deactivated += new EventHandler<DeactivatedEventArgs>(AppDeactivated);
- service.Closing += new EventHandler<ClosingEventArgs>(AppClosing);
- }
- else
- {
-
- }
+ Debug.WriteLine("Created new CordovaView instance");
// initializes native execution logic
configHandler = new ConfigHandler();
@@ -270,6 +256,18 @@ namespace WPCordovaClassLib
void CordovaBrowser_Loaded(object sender, RoutedEventArgs e)
{
+
+ PhoneApplicationService service = PhoneApplicationService.Current;
+ service.Activated += new EventHandler<Microsoft.Phone.Shell.ActivatedEventArgs>(AppActivated);
+ service.Launching += new EventHandler<LaunchingEventArgs>(AppLaunching);
+ service.Deactivated += new EventHandler<DeactivatedEventArgs>(AppDeactivated);
+ service.Closing += new EventHandler<ClosingEventArgs>(AppClosing);
+
+ foreach (IBrowserDecorator iBD in browserDecorators.Values)
+ {
+ iBD.AttachNativeHandlers();
+ }
+
this.bmHelper.ScrollDisabled = this.DisableBouncyScrolling;
@@ -322,6 +320,20 @@ namespace WPCordovaClassLib
}
}
+ private void CordovaBrowser_Unloaded(object sender, RoutedEventArgs e)
+ {
+ PhoneApplicationService service = PhoneApplicationService.Current;
+ service.Activated -= new EventHandler<Microsoft.Phone.Shell.ActivatedEventArgs>(AppActivated);
+ service.Launching -= new EventHandler<LaunchingEventArgs>(AppLaunching);
+ service.Deactivated -= new EventHandler<DeactivatedEventArgs>(AppDeactivated);
+ service.Closing -= new EventHandler<ClosingEventArgs>(AppClosing);
+
+ foreach (IBrowserDecorator iBD in browserDecorators.Values)
+ {
+ iBD.DetachNativeHandlers();
+ }
+ }
+
void AttachHardwareButtonHandlers()
{
PhoneApplicationFrame frame = Application.Current.RootVisual as PhoneApplicationFrame;
@@ -524,21 +536,6 @@ namespace WPCordovaClassLib
}
}
- private void CordovaBrowser_Unloaded(object sender, RoutedEventArgs e)
- {
- IBrowserDecorator console;
- if (browserDecorators.TryGetValue("ConsoleLog", out console))
- {
- ((ConsoleHelper)console).DetachHandler();
- }
-
- PhoneApplicationService service = PhoneApplicationService.Current;
- service.Activated -= new EventHandler<Microsoft.Phone.Shell.ActivatedEventArgs>(AppActivated);
- service.Launching -= new EventHandler<LaunchingEventArgs>(AppLaunching);
- service.Deactivated -= new EventHandler<DeactivatedEventArgs>(AppDeactivated);
- service.Closing -= new EventHandler<ClosingEventArgs>(AppClosing);
- }
-
private void CordovaBrowser_NavigationFailed(object sender, System.Windows.Navigation.NavigationFailedEventArgs e)
{
Debug.WriteLine("CordovaBrowser_NavigationFailed :: " + e.Uri.ToString());
@@ -546,10 +543,10 @@ namespace WPCordovaClassLib
private void CordovaBrowser_Navigated(object sender, System.Windows.Navigation.NavigationEventArgs e)
{
- foreach(IBrowserDecorator iBD in browserDecorators.Values)
- {
- iBD.InjectScript();
- }
+ foreach (IBrowserDecorator iBD in browserDecorators.Values)
+ {
+ iBD.InjectScript();
+ }
}
/// <summary>
@@ -576,5 +573,10 @@ namespace WPCordovaClassLib
(byte)(argb & 0xff));
return clr;
}
+
+ ~CordovaView()
+ {
+ Debug.WriteLine("CordovaView is destroyed");
+ }
}
}
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/IBrowserDecorator.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/IBrowserDecorator.cs b/template/cordovalib/IBrowserDecorator.cs
index bc1dbee..8425865 100644
--- a/template/cordovalib/IBrowserDecorator.cs
+++ b/template/cordovalib/IBrowserDecorator.cs
@@ -26,5 +26,7 @@ namespace WPCordovaClassLib.CordovaLib
WebBrowser Browser { get; set; }
void InjectScript();
bool HandleCommand(string cmd);
+ void AttachNativeHandlers();
+ void DetachNativeHandlers();
}
}
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/NativeExecution.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/NativeExecution.cs b/template/cordovalib/NativeExecution.cs
index 18ca910..fe35aea 100644
--- a/template/cordovalib/NativeExecution.cs
+++ b/template/cordovalib/NativeExecution.cs
@@ -52,21 +52,6 @@ namespace WPCordovaClassLib.Cordova
this.webBrowser = browser;
this.commands = new List<BaseCommand>();
- webBrowser.Unloaded += webBrowser_Unloaded;
- }
-
- /// <summary>
- /// Detaches event handlers to prevent memory leak on page navigation
- /// </summary>
- void webBrowser_Unloaded(object sender, RoutedEventArgs e)
- {
- for (int i = commands.Count - 1; i >= 0; i--)
- {
- if (commands[i] != null)
- {
- commands[i].DetachHandlers();
- }
- }
}
/// <summary>
@@ -115,6 +100,12 @@ namespace WPCordovaClassLib.Cordova
return;
}
+ // TODO: consider removing custom script functionality at all since we already marked it as absolute (see BaseCommand)
+ EventHandler<ScriptCallback> OnCustomScriptHandler = delegate(object o, ScriptCallback script)
+ {
+ this.InvokeScriptCallback(script);
+ };
+
EventHandler<PluginResult> OnCommandResultHandler = delegate(object o, PluginResult res)
{
if (res.CallbackId == null || res.CallbackId == commandCallParams.CallbackId)
@@ -123,6 +114,7 @@ namespace WPCordovaClassLib.Cordova
if (!res.KeepCallback)
{
bc.RemoveResultHandler(commandCallParams.CallbackId);
+ bc.OnCustomScript -= OnCustomScriptHandler;
}
}
};
@@ -130,11 +122,6 @@ namespace WPCordovaClassLib.Cordova
//bc.OnCommandResult += OnCommandResultHandler;
bc.AddResultHandler(commandCallParams.CallbackId, OnCommandResultHandler);
- EventHandler<ScriptCallback> OnCustomScriptHandler = delegate(object o, ScriptCallback script)
- {
- this.InvokeScriptCallback(script);
- };
-
bc.OnCustomScript += OnCustomScriptHandler;
ThreadStart methodInvokation = () =>
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/OrientationHelper.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/OrientationHelper.cs b/template/cordovalib/OrientationHelper.cs
index 299f9dd..0ec32fe 100644
--- a/template/cordovalib/OrientationHelper.cs
+++ b/template/cordovalib/OrientationHelper.cs
@@ -125,6 +125,16 @@ namespace WPCordovaClassLib.Cordova
// No commands are currently accepted.
return true;
}
+
+ public void AttachNativeHandlers()
+ {
+ // nothing todo
+ }
+
+ public void DetachNativeHandlers()
+ {
+ // nothing to do
+ }
}
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/cca4d44a/template/cordovalib/XHRHelper.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/XHRHelper.cs b/template/cordovalib/XHRHelper.cs
index 35913eb..1d72367 100644
--- a/template/cordovalib/XHRHelper.cs
+++ b/template/cordovalib/XHRHelper.cs
@@ -342,5 +342,15 @@ namespace WPCordovaClassLib.CordovaLib
return false;
}
+
+ public void AttachNativeHandlers()
+ {
+ // nothing todo
+ }
+
+ public void DetachNativeHandlers()
+ {
+ // nothing to do
+ }
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[3/7] cordova-wp8 git commit: Fix AutoloadPlugins
Posted by sg...@apache.org.
Fix AutoloadPlugins
Replace TakeWhile with Where to return all plugins for which onload="true".
Fixes https://issues.apache.org/jira/browse/CB-7858.
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/333200a5
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/333200a5
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/333200a5
Branch: refs/heads/3.7.x
Commit: 333200a5b2946ae63ba2eae65e36a7ad5a4b1c76
Parents: 2792153
Author: Marko <ma...@gmail.com>
Authored: Thu Nov 20 23:26:20 2014 +0200
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 10:58:26 2014 +0300
----------------------------------------------------------------------
template/cordovalib/ConfigHandler.cs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/333200a5/template/cordovalib/ConfigHandler.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/ConfigHandler.cs b/template/cordovalib/ConfigHandler.cs
index e2575f7..07a7936 100644
--- a/template/cordovalib/ConfigHandler.cs
+++ b/template/cordovalib/ConfigHandler.cs
@@ -186,8 +186,7 @@ namespace WPCordovaClassLib.CordovaLib
{
get
{
- // TODO:
- var res = from results in AllowedPlugins.TakeWhile(p => p.Value.isAutoLoad)
+ var res = from results in AllowedPlugins.Where(p => p.Value.isAutoLoad)
select results.Value.Name;
return res.ToArray<string>();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[2/7] cordova-wp8 git commit: CB-7892 XHR to local files poly should
only load/run once
Posted by sg...@apache.org.
CB-7892 XHR to local files poly should only load/run once
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/2a404053
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/2a404053
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/2a404053
Branch: refs/heads/3.7.x
Commit: 2a404053b73cfc1804a8760c1f46304e4edc84f9
Parents: 333200a
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Thu Dec 4 16:38:04 2014 -0800
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 10:58:26 2014 +0300
----------------------------------------------------------------------
template/cordovalib/XHRHelper.cs | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/2a404053/template/cordovalib/XHRHelper.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/XHRHelper.cs b/template/cordovalib/XHRHelper.cs
index 62f49ea..35913eb 100644
--- a/template/cordovalib/XHRHelper.cs
+++ b/template/cordovalib/XHRHelper.cs
@@ -37,6 +37,9 @@ namespace WPCordovaClassLib.CordovaLib
if (!win.__XHRShimAliases) {
win.__XHRShimAliases = {};
}
+ else {
+ return; // already initialized, this happens when navigating to #
+ }
win.__onXHRLocalCallback = function (responseCode, responseText, reqId) {
if (win.__XHRShimAliases[reqId]){
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[6/7] cordova-wp8 git commit: Update JS snapshot to version 3.7.1
(via coho)
Posted by sg...@apache.org.
Update JS snapshot to version 3.7.1 (via coho)
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/825be417
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/825be417
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/825be417
Branch: refs/heads/3.7.x
Commit: 825be417a1448c85d6d78cdfa651f96e4073ed7c
Parents: 993716c
Author: sgrebnov <v-...@microsoft.com>
Authored: Thu Dec 18 11:00:41 2014 +0300
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 11:00:41 2014 +0300
----------------------------------------------------------------------
template/www/cordova.js | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/825be417/template/www/cordova.js
----------------------------------------------------------------------
diff --git a/template/www/cordova.js b/template/www/cordova.js
index 5cc5dcd..1c23bf3 100644
--- a/template/www/cordova.js
+++ b/template/www/cordova.js
@@ -1,5 +1,5 @@
-// Platform: windowsphone
-// 91157c2e1bf3eb098c7e2ab31404e895ccb0df2a
+// Platform: wp8
+// 10ffabbd64eb74e345526739d72ab03b682c4793
/*
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
@@ -19,7 +19,7 @@
under the License.
*/
;(function() {
-var PLATFORM_VERSION_BUILD_LABEL = '3.7.0';
+var PLATFORM_VERSION_BUILD_LABEL = '3.7.1';
// file: src/scripts/require.js
/*jshint -W079 */
@@ -464,9 +464,14 @@ function each(objects, func, context) {
function clobber(obj, key, value) {
exports.replaceHookForTesting(obj, key);
- obj[key] = value;
+ var needsProperty = false;
+ try {
+ obj[key] = value;
+ } catch (e) {
+ needsProperty = true;
+ }
// Getters can only be overridden by getters.
- if (obj[key] !== value) {
+ if (needsProperty || obj[key] !== value) {
utils.defineGetter(obj, key, function() {
return value;
});
@@ -804,7 +809,7 @@ module.exports = channel;
});
-// file: src/windowsphone/exec.js
+// file: src/wp8/exec.js
define("cordova/exec", function(require, exports, module) {
var cordova = require('cordova'),
@@ -935,7 +940,7 @@ function replaceNavigator(origNavigator) {
for (var key in origNavigator) {
if (typeof origNavigator[key] == 'function') {
newNavigator[key] = origNavigator[key].bind(origNavigator);
- }
+ }
else {
(function(k) {
utils.defineGetterSetter(newNavigator,key,function() {
@@ -1063,7 +1068,7 @@ function replaceNavigator(origNavigator) {
for (var key in origNavigator) {
if (typeof origNavigator[key] == 'function') {
newNavigator[key] = origNavigator[key].bind(origNavigator);
- }
+ }
else {
(function(k) {
utils.defineGetterSetter(newNavigator,key,function() {
@@ -1118,7 +1123,7 @@ platform.bootstrap && platform.bootstrap();
* Create all cordova objects once native side is ready.
*/
channel.join(function() {
-
+
platform.initialize && platform.initialize();
// Fire event to notify that all objects are created
@@ -1236,7 +1241,7 @@ exports.reset();
});
-// file: src/windowsphone/platform.js
+// file: src/wp8/platform.js
define("cordova/platform", function(require, exports, module) {
module.exports = {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[4/7] cordova-wp8 git commit: remove debug trace
Posted by sg...@apache.org.
remove debug trace
Project: http://git-wip-us.apache.org/repos/asf/cordova-wp8/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-wp8/commit/29bf8850
Tree: http://git-wip-us.apache.org/repos/asf/cordova-wp8/tree/29bf8850
Diff: http://git-wip-us.apache.org/repos/asf/cordova-wp8/diff/29bf8850
Branch: refs/heads/3.7.x
Commit: 29bf8850e8b371db90fd857604489ab1fcaeb26f
Parents: cca4d44
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Mon Dec 15 23:56:53 2014 -0800
Committer: sgrebnov <v-...@microsoft.com>
Committed: Thu Dec 18 10:58:26 2014 +0300
----------------------------------------------------------------------
template/cordovalib/CordovaView.xaml.cs | 2 --
1 file changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-wp8/blob/29bf8850/template/cordovalib/CordovaView.xaml.cs
----------------------------------------------------------------------
diff --git a/template/cordovalib/CordovaView.xaml.cs b/template/cordovalib/CordovaView.xaml.cs
index 4c509e0..df91d73 100644
--- a/template/cordovalib/CordovaView.xaml.cs
+++ b/template/cordovalib/CordovaView.xaml.cs
@@ -136,8 +136,6 @@ namespace WPCordovaClassLib
return;
}
- Debug.WriteLine("Created new CordovaView instance");
-
// initializes native execution logic
configHandler = new ConfigHandler();
configHandler.LoadAppPackageConfig();
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org