You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/01/22 09:45:53 UTC

[GitHub] [logging-log4j2] ppkarwasz edited a comment on pull request #711: Use Log4j1XmlLayout instead of XmlLayout

ppkarwasz edited a comment on pull request #711:
URL: https://github.com/apache/logging-log4j2/pull/711#issuecomment-1019136281


   The schemas of the `XMLLayout` in Log4j 1.x and Log4j 2.x differ (e.g. the capitalization of the tags). There is a discussion about it in [LOG4J2-1522](https://issues.apache.org/jira/browse/LOG4J2-1522) and [LOG4J2-1525](https://issues.apache.org/jira/browse/LOG4J2-1525).
   
   I don't have a strong opinion whether `Log4j1XmlLayout` or the new `XmlLayout` should be used in this case, but the choice should be coherent: whichever layout is used by the `Log4j1ConfigurationFactory` should also be used by the `PropertiesConfigurationFactory` and `XmlConfigurationFactory`.
   
   If the factories are in sync there are no surprises, when a user converts his configuration using `Log4j1ConfigurationConverter`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org