You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/22 10:58:36 UTC
[GitHub] [superset] villebro opened a new pull request #15295: Villebro/fix timerange
villebro opened a new pull request #15295:
URL: https://github.com/apache/superset/pull/15295
### SUMMARY
Various improvements to time picker and time range filter:
- Defer rendering of time range filter to first visibility like other filters. This extra logic is required since the time range filter doesn't have a regular query like other filters.
- Make "Clear all" work.
- Avoid debounced time range evaluation request if the time range is unchanged. Will remove the double request on first render and also avoid re-requesting if the time range is changed back to its original value during debounce. Improvements affect native time range filter, Explore view and Filter Box where time picker is used.
### AFTER
https://user-images.githubusercontent.com/33317356/122913068-af397980-d361-11eb-86e7-fa161dbc3010.mp4
### BEFORE
https://user-images.githubusercontent.com/33317356/122913112-ba8ca500-d361-11eb-9c62-a1a3d51b86db.mp4
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #15295: fix(native-filters): improve time range filter performance
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #15295:
URL: https://github.com/apache/superset/pull/15295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org