You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Alex Karasulu <ak...@apache.org> on 2012/05/05 09:07:55 UTC
Code review here at Apache
Hi guys,
I was surprised to have not known about the existence of this nice tool
here for code reviews.
https://reviews.apache.org
Before discovering this I was thinking of setting up Gerrit especially if
we think about using Git down the line. This review tool might be something
we can use to collaborate on when having discussions about the code as
well. I wanted to post it here in case others might not be aware of it.
--
Best Regards,
-- Alex
Re: Code review here at Apache
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/5/12 9:32 PM, Alex Karasulu a écrit :
> On Sat, May 5, 2012 at 9:45 PM, Emmanuel Lécharny<el...@gmail.com> wrote:
>> Le 5/5/12 8:20 PM, Howard Chu a écrit :
>>
>>> Alex Karasulu wrote:
>>>> On Sat, May 5, 2012 at 11:06 AM, Emmanuel Lécharny<el...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
>>>>>
>>>>>> Hi guys,
>>>>>>
>>>>>> I was surprised to have not known about the existence of this nice tool
>>>>>> here for code reviews.
>>>>>
>>>>> You obviously have known that this tool was existing, but you forgot
>>>>> about it, as you have commented some piece of code we were discussing 6
>>>>> months ago...
>>>>>
>>>>> https://reviews.apache.org/r/14/
>>>>>
>>>>>
>>>> I cannot believe this. I used it, forgot about it, then thought I
>>>> rediscovered it. I must have Alzheimer's disease setting in. I'm
>>>> slightly worried now :-).
>>>
>>> Memory is the second thing to go. I've forgotten what the first was... ;)
>>
>> Do you remember Alzeihmer's firstname ?
>>
>> This is how it begins...
> Come on guys stop making fun of me. You're hurting my feelings hehehe.
That does not matter... Tomorrow morning, you will have forgotten
everything ;-)
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: Code review here at Apache
Posted by Alex Karasulu <ak...@apache.org>.
On Sat, May 5, 2012 at 9:45 PM, Emmanuel Lécharny <el...@gmail.com> wrote:
> Le 5/5/12 8:20 PM, Howard Chu a écrit :
>
>> Alex Karasulu wrote:
>>>
>>> On Sat, May 5, 2012 at 11:06 AM, Emmanuel Lécharny <el...@gmail.com>
>>> wrote:
>>>>
>>>>
>>>> Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
>>>>
>>>>> Hi guys,
>>>>>
>>>>> I was surprised to have not known about the existence of this nice tool
>>>>> here for code reviews.
>>>>
>>>>
>>>> You obviously have known that this tool was existing, but you forgot
>>>> about it, as you have commented some piece of code we were discussing 6
>>>> months ago...
>>>>
>>>> https://reviews.apache.org/r/14/
>>>>
>>>>
>>>
>>> I cannot believe this. I used it, forgot about it, then thought I
>>> rediscovered it. I must have Alzheimer's disease setting in. I'm
>>> slightly worried now :-).
>>
>>
>> Memory is the second thing to go. I've forgotten what the first was... ;)
>
>
> Do you remember Alzeihmer's firstname ?
>
> This is how it begins...
Come on guys stop making fun of me. You're hurting my feelings hehehe.
--
Best Regards,
-- Alex
Re: Code review here at Apache
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/5/12 8:20 PM, Howard Chu a écrit :
> Alex Karasulu wrote:
>> On Sat, May 5, 2012 at 11:06 AM, Emmanuel Lécharny
>> <el...@gmail.com> wrote:
>>>
>>> Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
>>>
>>>> Hi guys,
>>>>
>>>> I was surprised to have not known about the existence of this nice
>>>> tool
>>>> here for code reviews.
>>>
>>> You obviously have known that this tool was existing, but you forgot
>>> about it, as you have commented some piece of code we were
>>> discussing 6 months ago...
>>>
>>> https://reviews.apache.org/r/14/
>>>
>>>
>>
>> I cannot believe this. I used it, forgot about it, then thought I
>> rediscovered it. I must have Alzheimer's disease setting in. I'm
>> slightly worried now :-).
>
> Memory is the second thing to go. I've forgotten what the first was... ;)
Do you remember Alzeihmer's firstname ?
This is how it begins...
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: Code review here at Apache
Posted by Howard Chu <hy...@symas.com>.
Alex Karasulu wrote:
> On Sat, May 5, 2012 at 11:06 AM, Emmanuel Lécharny <el...@gmail.com> wrote:
>>
>> Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
>>
>>> Hi guys,
>>>
>>> I was surprised to have not known about the existence of this nice tool
>>> here for code reviews.
>>
>> You obviously have known that this tool was existing, but you forgot about it, as you have commented some piece of code we were discussing 6 months ago...
>>
>> https://reviews.apache.org/r/14/
>>
>>
>
> I cannot believe this. I used it, forgot about it, then thought I
> rediscovered it. I must have Alzheimer's disease setting in. I'm
> slightly worried now :-).
Memory is the second thing to go. I've forgotten what the first was... ;)
> Sorry for the noise.
>
> --
> Best Regards,
> -- Alex
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Re: Code review here at Apache
Posted by Alex Karasulu <ak...@apache.org>.
On Sat, May 5, 2012 at 11:06 AM, Emmanuel Lécharny <el...@gmail.com> wrote:
>
> Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
>
>> Hi guys,
>>
>> I was surprised to have not known about the existence of this nice tool
>> here for code reviews.
>
> You obviously have known that this tool was existing, but you forgot about it, as you have commented some piece of code we were discussing 6 months ago...
>
> https://reviews.apache.org/r/14/
>
>
I cannot believe this. I used it, forgot about it, then thought I
rediscovered it. I must have Alzheimer's disease setting in. I'm
slightly worried now :-).
Sorry for the noise.
--
Best Regards,
-- Alex
Re: Code review here at Apache
Posted by Emmanuel Lécharny <el...@gmail.com>.
Le 5/5/12 9:07 AM, Alex Karasulu a écrit :
> Hi guys,
>
> I was surprised to have not known about the existence of this nice tool
> here for code reviews.
You obviously have known that this tool was existing, but you forgot
about it, as you have commented some piece of code we were discussing 6
months ago...
https://reviews.apache.org/r/14/
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com