You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "songwanging (JIRA)" <ji...@apache.org> on 2016/03/16 06:01:33 UTC
[jira] [Commented] (NUTCH-2076) exceptions are not handled when
using method waitForCompletion in a try block
[ https://issues.apache.org/jira/browse/NUTCH-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196768#comment-15196768 ]
songwanging commented on NUTCH-2076:
------------------------------------
Yes,since the method waitForCompletion might throw many exceptions, e.g., IOException, InterruptedException, ClassNotFoundException, so when calling this function in a try block, we should use a catch block to handle potential Exceptions. I perfer to pass all possible exceptions to the calling function, here is the run().
> exceptions are not handled when using method waitForCompletion in a try block
> -----------------------------------------------------------------------------
>
> Key: NUTCH-2076
> URL: https://issues.apache.org/jira/browse/NUTCH-2076
> Project: Nutch
> Issue Type: Bug
> Components: crawldb
> Affects Versions: 2.2, 2.3
> Reporter: songwanging
> Priority: Minor
>
> Locations: src\java\org\apache\nutch\crawl\WebTableReader.java
> when using function waitForCompletion in a try block, exceptions are not handled :
> waitForCompletion might throw : IOException, InterruptedException, ClassNotFoundException
> so when calling this function in a try block, we should use a catch block to handle potential Exceptions.
> public Map<String, Object> run(Map<String, Object> args) throws Exception {
> ...
> try {
> currentJob.waitForCompletion(true);
> } finally {
> ToolUtil.recordJobStatus(null, currentJob, results);
> if (!currentJob.isSuccessful()) {
> fileSystem.delete(tmpFolder, true);
> return results;
> }
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)