You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/19 08:52:57 UTC

[GitHub] [flink] dawidwys commented on a change in pull request #14122: [FLINK-20098] Don't add flink-connector-files to flink-dist, make dependencies explicit

dawidwys commented on a change in pull request #14122:
URL: https://github.com/apache/flink/pull/14122#discussion_r526688996



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -31,6 +31,14 @@ under the License.
 	<name>Flink : E2E Tests : Common Kafka</name>
 
 	<dependencies>
+<!--		&lt;!&ndash; The SQL Client test uses a Table FileSource, which is not included in the normal table-->
+<!--		dependencies &ndash;&gt;-->
+<!--		<dependency>-->
+<!--			<groupId>org.apache.flink</groupId>-->
+<!--			<artifactId>flink-connector-files</artifactId>-->
+<!--			<version>${project.version}</version>-->
+<!--		</dependency>-->
+

Review comment:
       Remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org