You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "lkishalmi (via GitHub)" <gi...@apache.org> on 2024/01/07 17:32:45 UTC

[PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

lkishalmi opened a new pull request, #6926:
URL: https://github.com/apache/netbeans/pull/6926

   It's quite possible that Gradle 8.6 would be released before NB21, so let's start the upgrade now, and maybe add another PR for the final 8.6 during the RC cycle.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1880143056

   Well, I'm about to update the New Gradle project wizard and use: https://docs.gradle.org/8.6-rc-1/release-notes.html#generating-without-interactive-questions
   
   Not strictly necessary, though...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6 [netbeans]

Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1929352454

   Yes, can be merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1888833888

   Well, is there a list of which areas of Gradle support are Tooling API version dependent?  In _theory_ the tooling API version shouldn't have an effect on projects.  If we can communicate to testers during rc phase which features are dependent, we could potentially focus testing on upgrades?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1886578031

   how can there be a release 5 days before NB feature freeze? There is no wiggle room to delay pending NetBeans PRs right now. They have to get in this weekend or they will miss NB 21.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1925785155

   >  NetBeans 21-rc2 running a Java 21 Project with Gradle 8.6, where the Java Runtime for Gradle is Java 17.
   
   And how about running 21-rc2 with the IDE and Gradle runtime set to Java 21?  I'm not against merging this change, even so late. However, isn't the main issue that we're warning people about JDK based on the Tooling API version rather than the project Gradle version?
   
   Running on a clean userdir, a new Gradle project is currently set up with 8.5, and I presume will pick up 8.6 as and when the Gradle people designate it `latest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1886589789

   > how can there be a release 5 days before NB feature freeze? There is no wiggle room to delay pending NetBeans PRs right now. They have to get in this weekend or they will miss NB 21.
   
   Sorry; I didn't match the different schedules right. I didn't meant to request a feature slip, the `vsnetbeans` is already branched anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1880126375

   > It's quite possible that Gradle 8.6 would be released before NB21
   
   And if it isn't, do we wait on it??
   
   Making the IDE 8.6 aware is a good thing.  But the tooling API is meant to be forwards compatible.  What do we have that won't work with 8.6 even if we ship with 8.5 of the tooling API?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6 [netbeans]

Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1926613578

   It has to be tested with latest micronaut-core which is the ultimate test for Gradle all the time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1886722011

   Well, I don't know _why_ we're releasing a VSNetBeans release at the same time as 21-rc1, but that's a discussion for dev@ where it should have happened in the first place ...
   
   On this change, @lkishalmi if there's a good reason to bring in an rc of Gradle tooling then go ahead IMO.  As long as it doesn't "leak" into the UI I don't see a problem.  ie. like the use of `latest` in `init`, the user shouldn't ever be aware we're using an rc or that potentially becomes a delay to our release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1887340366

   VSNetBeans 20.0.301 is branched and being released. There is no problem with this PR making it to 21. If it breaks something issue will be filed. Svata just mentioned we have to test Gradle projects carefully during 21 testing as these are breaking more easily than Maven....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6-rc-1 [netbeans]

Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1925397433

   Above: NetBeans 21-rc2 running a Java 21 Project with Gradle 8.6, where the Java Runtime for Gradle is Java 17.
   
   Below: This PR running a Java 21 Project with Gradle 8.6, while the Java Runtime for Gradle is Java 21.
   
   ![image](https://github.com/apache/netbeans/assets/1381701/2f1741c7-4252-489d-b2ca-001d85fd3d27)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #6926:
URL: https://github.com/apache/netbeans/pull/6926#issuecomment-1929224173

   @MartinBalin I intend to merge this after #7029 unless you have specific concerns now?  Are there test micronaut-core projects to consider / look at?  Note that this shouldn't change the version of Gradle used in those projects, unless they don't use the wrapper?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] Update Gradle Tooling API to 8.6 [netbeans]

Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #6926:
URL: https://github.com/apache/netbeans/pull/6926


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists