You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gabor Kaszab (Code Review)" <ge...@cloudera.org> on 2018/02/16 12:51:50 UTC
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Gabor Kaszab has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9352
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
There are cancellation checks in HDFS scanner code that are using
ScannerContext::cancelled(), however, if an internal cancellation
happens then RuntimeState::is_cancelled() should also be checked to
detect these. As a solution I extended ScannerContext::cancelled() to
check RuntimeState::is_cancelled() as well.
Creating automatic tests for this is difficult as the result of the
query is actually the same with and without this change. With manual
tests I verifyed that in case an internal cancel happens (I made the
exchange node fail during a select query) this change prevents
CommitRows() being executed multiple times even if the query had been
cancelled before the first call.
Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
---
M be/src/exec/scanner-context.cc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/9352/1
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 1
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 00:45:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
There are cancellation checks in HDFS scanner code that are using
ScannerContext::cancelled(), however, if an internal cancellation
happens then RuntimeState::is_cancelled() should also be checked to
detect these. As a solution I extended ScannerContext::cancelled() to
check RuntimeState::is_cancelled() as well.
Creating automatic tests for this is difficult as the result of the
query is actually the same with and without this change. With manual
tests I verifyed that in case an internal cancel happens (I made the
exchange node fail during a select query) this change prevents
CommitRows() being executed multiple times even if the query had been
cancelled before the first call.
Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Reviewed-on: http://gerrit.cloudera.org:8080/9352
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/scanner-context.cc
M be/src/exec/scanner-context.h
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 4
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 21:00:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1952/
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 21:01:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 3
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 21:00:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Hello Attila Jeges, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9352
to look at the new patch set (#2).
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
There are cancellation checks in HDFS scanner code that are using
ScannerContext::cancelled(), however, if an internal cancellation
happens then RuntimeState::is_cancelled() should also be checked to
detect these. As a solution I extended ScannerContext::cancelled() to
check RuntimeState::is_cancelled() as well.
Creating automatic tests for this is difficult as the result of the
query is actually the same with and without this change. With manual
tests I verifyed that in case an internal cancel happens (I made the
exchange node fail during a select query) this change prevents
CommitRows() being executed multiple times even if the query had been
cancelled before the first call.
Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
---
M be/src/exec/scanner-context.cc
M be/src/exec/scanner-context.h
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/9352/2
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6423: HDFS scanner doesn't check RuntimeState::is cancelled()
Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/9352 )
Change subject: IMPALA-6423: HDFS scanner doesn't check RuntimeState::is_cancelled()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eb960d9d6f2dde4b2cb4988aa06288d11802b9a
Gerrit-Change-Number: 9352
Gerrit-PatchSet: 2
Gerrit-Owner: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Feb 2018 15:18:56 +0000
Gerrit-HasComments: No