You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lukecwik <gi...@git.apache.org> on 2017/10/04 23:37:18 UTC
[GitHub] beam pull request #3944: [BEAM-3016] Fix blocking issue within run() when ch...
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/3944
[BEAM-3016] Fix blocking issue within run() when channel terminates while blocking within DirectStreamObserver.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam fn_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3944
----
commit d4e6c4d8d055e395d28e9d9c9ad8740c82698082
Author: Luke Cwik <lc...@google.com>
Date: 2017-10-04T23:34:54Z
[BEAM-3016] Fix blocking issue within run() when channel terminates while blocking within DirectStreamObserver.
----
---
[GitHub] beam pull request #3944: [BEAM-3016] Fix blocking issue within run() when ch...
Posted by lukecwik <gi...@git.apache.org>.
Github user lukecwik closed the pull request at:
https://github.com/apache/beam/pull/3944
---
[GitHub] beam pull request #3944: [BEAM-3016] Fix blocking issue within run() when ch...
Posted by lukecwik <gi...@git.apache.org>.
GitHub user lukecwik reopened a pull request:
https://github.com/apache/beam/pull/3944
[BEAM-3016] Fix blocking issue within run() when channel terminates while blocking within DirectStreamObserver.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam fn_api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3944.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3944
----
commit 43964a933ae2d3ce72b7658dce885fde1c8e9865
Author: Luke Cwik <lc...@google.com>
Date: 2017-10-06T16:09:17Z
[BEAM-3016] Fix blocking issue within run() when channel terminates while blocking within DirectStreamObserver.
----
---
[GitHub] beam pull request #3944: [BEAM-3016] Fix blocking issue within run() when ch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3944
---