You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Eric Pugh (Jira)" <ji...@apache.org> on 2022/12/03 00:52:00 UTC
[jira] [Commented] (SOLR-8975) SolrClient setters should be deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-8975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642755#comment-17642755 ]
Eric Pugh commented on SOLR-8975:
---------------------------------
Heads up that as David Smiley correctly pointed out, the work I had done on [https://github.com/apache/solr/pull/1158] really belonged as part of this JIRA. So I just opened up a PR that references this JIRA.
I'd like to get it merged, and then go through the long list of subtasks and close the ones that are completed, or get new PR's in to finish them!
> SolrClient setters should be deprecated in favor of SolrClientBuilder methods
> -----------------------------------------------------------------------------
>
> Key: SOLR-8975
> URL: https://issues.apache.org/jira/browse/SOLR-8975
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: Jason Gerlowski
> Priority: Minor
> Attachments: SOLR-8975.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SOLR-8097 added a builder layer on top of each {{SolrClient}} implementation.
> Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
> - reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org