[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3343: Implement MySQL time service

[GitBox <gi...@apache.org>]

terrymanu commented on issue #3343: Implement MySQL time service
URL: https://github.com/apache/incubator-shardingsphere/pull/3343#issuecomment-545421398
 
 
   > > Please fix all code review suggestions.
   > > And more more question for design, how to enable this SPI? Does need user add to SPI file by themselves?
   > > Maybe we should consider about spilt this code to a new module and setup SPI fine in the new module.
   > > If user import this module, they can load from SPI automatically.
   > > For the default time service , maybe we should consider about do not use SPI to load it. The logic maybe better `if no other SPI, just use default one`.
   > > How do you think?
   > 
   > that sound great. user can controll whether they need to use `MySQLTimeService`. if do that. what is the module name？ and where should the module place on？
   
   The name maybe as `database-time-service`, and we can put it below route module?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services