You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Xu-Wentao (via GitHub)" <gi...@apache.org> on 2023/05/18 11:42:47 UTC
[GitHub] [shardingsphere-on-cloud] Xu-Wentao opened a new pull request, #373: feat(storage-node): unregister storage unit when storage node be deleted
Xu-Wentao opened a new pull request, #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Unregister storage unit in shardingsphere If `StorageNode` is `Registered` when it been deleted.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [x] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #373: feat(storage-node): unregister storage unit when storage node be deleted
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373#issuecomment-1553948964
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=373)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #373: feat(storage-node): unregister storage unit when storage node be deleted
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] codecov-commenter commented on pull request #373: feat(storage-node): unregister storage unit when storage node be deleted
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373#issuecomment-1552939558
## [Codecov](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#373](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8672fee) into [main](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/commit/559108f7e21f1e642274f2d76b60b88d090dbd3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (559108f) will **increase** coverage by `4.23%`.
> The diff coverage is `62.96%`.
```diff
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 44.39% 48.63% +4.23%
==========================================
Files 46 46
Lines 4919 5019 +100
==========================================
+ Hits 2184 2441 +257
+ Misses 2549 2361 -188
- Partials 186 217 +31
```
| [Impacted Files](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...rator/pkg/reconcile/storagenode/aws/rdsinstance.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3JlY29uY2lsZS9zdG9yYWdlbm9kZS9hd3MvcmRzaW5zdGFuY2UuZ28=) | `22.14% <0.00%> (-0.66%)` | :arrow_down: |
| [...here-operator/pkg/shardingsphere/shardingsphere.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc3BoZXJlLmdv) | `47.31% <ø> (+2.75%)` | :arrow_up: |
| [pitr/cli/internal/pkg/shardingsphere-proxy.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl0ci9jbGkvaW50ZXJuYWwvcGtnL3NoYXJkaW5nc3BoZXJlLXByb3h5Lmdv) | `15.51% <33.33%> (+15.51%)` | :arrow_up: |
| [...perator/pkg/controllers/storage\_node\_controller.go](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hhcmRpbmdzcGhlcmUtb3BlcmF0b3IvcGtnL2NvbnRyb2xsZXJzL3N0b3JhZ2Vfbm9kZV9jb250cm9sbGVyLmdv) | `55.25% <66.93%> (+8.00%)` | :arrow_up: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/shardingsphere-on-cloud/pull/373/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] wbtlb commented on pull request #373: feat(storage-node): unregister storage unit when storage node be deleted
Posted by "wbtlb (via GitHub)" <gi...@apache.org>.
wbtlb commented on PR #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373#issuecomment-1553900564
approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #373: feat(storage-node): unregister storage unit when storage node be deleted
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #373:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/373#issuecomment-1552934500
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=373)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=373&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=373&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org