[GitHub] [tvm] Lunderberg commented on issue #8903: [Tracking][Vulkan] Extending topi/unit tests to run on Vulkan

[GitBox <gi...@apache.org>]

Lunderberg commented on issue #8903:
URL: https://github.com/apache/tvm/issues/8903#issuecomment-910477439


   @mbrookhart Regarding your comments that several of the failing unit tests had run correctly on vulkan in the past, the main breaking point was in #8127, which reads the device parameters from the physical device when the target is `"vulkan -from_device=0"`.  Several of the unit tests had a hard-coded target of `"vulkan"`, tried to run with the minimum vulkan capabilities, and failed at codegen because the capability requested (e.g. 64-bit float support) wasn't listed in the target.  Those fixes came along for free by parametrizing the topi tests, since the default vulkan test target uses the device query.
   
   That said, at some point I want to ensure all tests either run correctly or have an appropriate `xfail` for the minimum vulkan feature set, but that will be a different issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org