[GitHub] [superset] robdiciuccio commented on pull request #12903: fix(explore): hide time section for datasets with no time column

[GitBox <gi...@apache.org>]

robdiciuccio commented on pull request #12903:
URL: https://github.com/apache/superset/pull/12903#issuecomment-772910493


   I would think collapsing it rather than completely removing it from the UI would make this less confusing for users. Removing based on no temporal fields is also relying heavily on the automatic detection or manual identification of these fields, which may be inaccurate or not set correctly. Not displaying the UI at all may lead the user to believe that filtering by time range is not possible at all in a visualization.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org