You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by rf...@apache.org on 2007/11/20 21:10:05 UTC

svn commit: r596808 - /lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java

Author: rfrovarp
Date: Tue Nov 20 12:10:04 2007
New Revision: 596808

URL: http://svn.apache.org/viewvc?rev=596808&view=rev
Log:
Refactored to remove bad Thread.run(). Fixes 43919.

Modified:
    lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java

Modified: lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java
URL: http://svn.apache.org/viewvc/lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java?rev=596808&r1=596807&r2=596808&view=diff
==============================================================================
--- lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java (original)
+++ lenya/trunk/src/modules-core/observation/java/src/org/apache/lenya/cms/observation/ObservationManager.java Tue Nov 20 12:10:04 2007
@@ -82,24 +82,11 @@
         return allListeners;
     }
 
-    protected abstract class Notifier implements Runnable {
-
-        private Set listeners;
-        private RepositoryEvent event;
-
-        protected Notifier(Set listeners, RepositoryEvent event) {
-            this.listeners = listeners;
-            this.event = event;
-        }
-
-        public void run() {
+    protected void notify(Set listeners, RepositoryEvent event) {
             for (Iterator i = listeners.iterator(); i.hasNext();) {
                 RepositoryListener listener = (RepositoryListener) i.next();
-                notify(listener, event);
+                listener.eventFired(event);
             }
-        }
-
-        protected abstract void notify(RepositoryListener listener, RepositoryEvent event);
     }
 
     public void eventFired(RepositoryEvent event) {
@@ -111,12 +98,7 @@
         } else {
             listeners = this.listeners;
         }
-        Notifier notifier = new Notifier(listeners, event) {
-            public void notify(RepositoryListener listener, RepositoryEvent event) {
-                listener.eventFired(event);
-            }
-        };
-        new Thread(notifier).run();
+        notify(listeners, event);
     }
 
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@lenya.apache.org
For additional commands, e-mail: commits-help@lenya.apache.org