You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2015/09/08 22:59:03 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/75
[TRAFODION-28] Update the copyrights in all Trafodion source files to make them conform to ASF standards.
This change addresses the product banners to reflect Apache Trafodion copyright and name.
The copyright and product names have been made envvars in sqencom.sh so we dont' have to touch code in the future to make any updates.
Changed sqvers output to give detail to show the Apache Trafodion name in it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion sandhya_copyright
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 8dec72443f0461b022082cf70d0a5e51adc4ca45
Author: Sandhya Sundaresan <sa...@dev01.trafodion.org>
Date: 2015-09-08T04:17:59Z
Changes to product banners to reflect Apache Trafodion copyrights. sqlci, trafciand arkcmo, udr banners will nw read an envvar from sqenvcom.sh to determine copyright and banner header.
sqvers and genverhdr have been modified to indicate the product version. It will now show it is "Apache_trafodion" in the sqvers output for all binaries, libraries and jars.
This addresses part of JIRA TRAFODION-28
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39072675
--- Diff: core/sql/regress/tools/setuplnxenv ---
@@ -79,6 +79,8 @@ fi
# Finally, add the regression variables and make sure the directories
# actually exist
#
+echo "MY_SQROOt"
--- End diff --
Thanks for catching this. It was some erroneous typo that crept in .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39063264
--- Diff: core/sql/regress/tools/setuplnxenv ---
@@ -79,6 +79,8 @@ fi
# Finally, add the regression variables and make sure the directories
# actually exist
#
+echo "MY_SQROOt"
--- End diff --
Why lower case 't' on MY_SQROOt?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39072890
--- Diff: core/sql/regress/udr/EXPECTED100.SB ---
@@ -1706,7 +1706,7 @@ OUT2
>>
>>obey TEST100(udrtrace);
>>log;
-Trafodion Conversational Interface @version@
+Conversational Interface @version@
--- End diff --
Leaving the old filters as is for now since I noticed they are spread across other filter files.The new filter is more general and should cover future copyright changes as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39063369
--- Diff: core/sql/regress/udr/EXPECTED100.SB ---
@@ -1706,7 +1706,7 @@ OUT2
>>
>>obey TEST100(udrtrace);
>>log;
-Trafodion Conversational Interface @version@
+Conversational Interface @version@
--- End diff --
Should the Hewlett-Packard text go away here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39062987
--- Diff: core/sqf/sqenvcom.sh ---
@@ -29,13 +29,16 @@
# * Add an entry in sqf/LocalSettingsTemplate.sh to make path configurable.
##############################################################
+#Product version (Trafodion, Enterprise or Enterprise Adv)
--- End diff --
Instead of using the terms "Enterprise" or "Enterprise Adv", perhaps it would be better to say, "(Trafodion or derivative product)"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-28] Update the copyri...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/75#discussion_r39072597
--- Diff: core/sqf/sqenvcom.sh ---
@@ -29,13 +29,16 @@
# * Add an entry in sqf/LocalSettingsTemplate.sh to make path configurable.
##############################################################
+#Product version (Trafodion, Enterprise or Enterprise Adv)
--- End diff --
Good suggestion . Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---