You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ham1 <gi...@git.apache.org> on 2017/12/11 21:49:52 UTC
[GitHub] jmeter pull request #355: BoundaryExtractor refactor
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/355
BoundaryExtractor refactor
## Description
* Refactored `BoundaryExtractor`
* Ported tests to Spock
* Added more tests
* Other code tidyup while in the vicinity
## Motivation and Context
Took the need for a minor correction too far... but hopefully the code is now slightly easier to understand.
## How Has This Been Tested?
unit tests and manual testing with Boundary Extractor GUI
## Screenshots (if appropriate):
## Types of changes
- Dev improvement
- Bug fix (non-breaking change which fixes an issue)
## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] My code follows the [code style][style-guide] of this project.
- [x] I have updated the documentation accordingly.
[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ham1/jmeter boundary_extractor_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit f1cd0042471ee698a0f9da266bdef5eb88181e15
Author: Graham Russell <gr...@ham1.co.uk>
Date: 2017-12-10T21:43:02Z
BoundaryExtractor refactor
----
---
[GitHub] jmeter issue #355: BoundaryExtractor refactor
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/jmeter/pull/355
# [Codecov](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=h1) Report
> Merging [#355](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=desc) into [trunk](https://codecov.io/gh/apache/jmeter/commit/427907f9d2ca45f8077acf9398a140834d75e3bd?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `93.02%`.
[](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## trunk #355 +/- ##
============================================
- Coverage 58.19% 58.15% -0.04%
- Complexity 10210 10223 +13
============================================
Files 1161 1161
Lines 74189 74116 -73
Branches 7322 7316 -6
============================================
- Hits 43174 43102 -72
+ Misses 28517 28514 -3
- Partials 2498 2500 +2
```
| [Impacted Files](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../jmeter/visualizers/RenderAsBoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvdmlzdWFsaXplcnMvUmVuZGVyQXNCb3VuZGFyeUV4dHJhY3Rvci5qYXZh) | `4.76% <0%> (-0.12%)` | `3 <0> (ø)` | |
| [.../jmeter/testelement/AbstractScopedTestElement.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdGVzdGVsZW1lbnQvQWJzdHJhY3RTY29wZWRUZXN0RWxlbWVudC5qYXZh) | `100% <100%> (ø)` | `18 <0> (-1)` | :arrow_down: |
| [.../core/org/apache/jmeter/threads/JMeterContext.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvdGhyZWFkcy9KTWV0ZXJDb250ZXh0LmphdmE=) | `86.44% <100%> (ø)` | `25 <2> (ø)` | :arrow_down: |
| [...ache/jmeter/extractor/BoundaryExtractorSpec.groovy](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-dGVzdC9zcmMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0JvdW5kYXJ5RXh0cmFjdG9yU3BlYy5ncm9vdnk=) | `100% <100%> (ø)` | `25 <25> (?)` | |
| [...nts/org/apache/jmeter/extractor/HtmlExtractor.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0h0bWxFeHRyYWN0b3IuamF2YQ==) | `85.45% <100%> (ø)` | `41 <2> (ø)` | :arrow_down: |
| [...org/apache/jmeter/extractor/BoundaryExtractor.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvbXBvbmVudHMvb3JnL2FwYWNoZS9qbWV0ZXIvZXh0cmFjdG9yL0JvdW5kYXJ5RXh0cmFjdG9yLmphdmE=) | `85.31% <86.51%> (-0.72%)` | `58 <28> (+6)` | |
| [...c/core/org/apache/jmeter/reporters/Summariser.java](https://codecov.io/gh/apache/jmeter/pull/355/diff?src=pr&el=tree#diff-c3JjL2NvcmUvb3JnL2FwYWNoZS9qbWV0ZXIvcmVwb3J0ZXJzL1N1bW1hcmlzZXIuamF2YQ==) | `85.38% <0%> (ø)` | `18% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=footer). Last update [427907f...969b587](https://codecov.io/gh/apache/jmeter/pull/355?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] jmeter issue #355: BoundaryExtractor refactor
Posted by ham1 <gi...@git.apache.org>.
Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/355
Rebased :)
---
[GitHub] jmeter pull request #355: BoundaryExtractor refactor
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/355
---
[GitHub] jmeter issue #355: BoundaryExtractor refactor
Posted by pmouawad <gi...@git.apache.org>.
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/355
Hi Graham,
Thanks for the PR.
would it be possible to update it with last trunk as there has been an intermediate commit which changes things a bit.
Thanks
---