Re: [PR] [FLINK-36048] Add CompiledPlan annotations to BatchExecRank [flink]

["twalthr (via GitHub)" <gi...@apache.org>]

twalthr commented on code in PR #25206:
URL: https://github.com/apache/flink/pull/25206#discussion_r1840565494


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecRank.java:
##########
@@ -37,20 +39,48 @@
 import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
 import org.apache.flink.table.types.logical.RowType;
 
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonCreator;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+
 import java.util.Collections;
+import java.util.List;
+
+import static org.apache.flink.table.planner.plan.nodes.exec.stream.StreamExecRank.FIELD_NAME_OUTPUT_RANK_NUMBER;
 
 /**
  * {@link BatchExecNode} for Rank.
  *
  * <p>This node supports two-stage(local and global) rank to reduce data-shuffling.
  */
+@ExecNodeMetadata(
+        name = "batch-exec-rank",

Review Comment:
   I cannot find this identifier in any of the attached plans. Maybe we need some additional test cases to trigger it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org