You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mf...@apache.org on 2016/01/13 07:06:06 UTC
[06/15] maven-surefire git commit: [SUREFIRE] fixed little checkstyle
issues
[SUREFIRE] fixed little checkstyle issues
Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/641f9717
Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/641f9717
Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/641f9717
Branch: refs/heads/SUREFIRE-1217
Commit: 641f971715d713c3d934c27f49030082e067c0c7
Parents: d618491
Author: Tibor17 <ti...@lycos.com>
Authored: Wed Jan 13 01:20:03 2016 +0100
Committer: Tibor17 <ti...@lycos.com>
Committed: Wed Jan 13 01:20:03 2016 +0100
----------------------------------------------------------------------
.../org/apache/maven/surefire/common/junit4/Notifier.java | 9 +++++----
.../org/apache/maven/surefire/testng/TestNGExecutor.java | 1 +
2 files changed, 6 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/641f9717/surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/Notifier.java
----------------------------------------------------------------------
diff --git a/surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/Notifier.java b/surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/Notifier.java
index 20b711e..dfa3948 100644
--- a/surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/Notifier.java
+++ b/surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/Notifier.java
@@ -74,17 +74,16 @@ public class Notifier
return new Notifier()
{
@Override
- public Notifier asFailFast( boolean failFast )
+ public void asFailFast( @SuppressWarnings( { "unused", "checkstyle:hiddenfieldcheck" } ) boolean failFast )
{
throw new UnsupportedOperationException( "pure notifier" );
}
};
}
- public Notifier asFailFast( boolean failFast )
+ public void asFailFast( boolean enableFailFast )
{
- this.failFast = failFast;
- return this;
+ failFast = enableFailFast;
}
public final boolean isFailFast()
@@ -93,6 +92,7 @@ public class Notifier
}
@Override
+ @SuppressWarnings( "checkstyle:redundantthrowscheck" ) // checkstyle is wrong here, see super.fireTestStarted()
public final void fireTestStarted( Description description ) throws StoppedByUserException
{
// If fireTestStarted() throws exception (== skipped test), the class must not be removed from testClassNames.
@@ -130,6 +130,7 @@ public class Notifier
return this;
}
+ @SuppressWarnings( "unused" )
public final Notifier addListeners( RunListener... given )
{
for ( RunListener listener : given )
http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/641f9717/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java
----------------------------------------------------------------------
diff --git a/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java b/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java
index 529ed89..3c78b60 100644
--- a/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java
+++ b/surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java
@@ -73,6 +73,7 @@ final class TestNGExecutor
throw new IllegalStateException( "not instantiable constructor" );
}
+ @SuppressWarnings( "checkstyle:parameternumbercheck" )
static void run( Iterable<Class<?>> testClasses, String testSourceDirectory,
Map<String, String> options, // string,string because TestNGMapConfigurator#configure()
RunListener reportManager, File reportsDirectory,