You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2015/07/25 03:52:05 UTC

[jira] [Commented] (HTRACE-217) Rename ProcessId to TracerId

    [ https://issues.apache.org/jira/browse/HTRACE-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641340#comment-14641340 ] 

Colin Patrick McCabe commented on HTRACE-217:
---------------------------------------------

I looked at this, and it should still apply to the current master.  I think that this is a good change because it gets rid of the confusion when discussing how we tag spans.  "Does your process ID include a process ID?" is just a silly question... but "does your HTrace tracer ID include an OS process ID" makes sense.  It's also important to note that this is tracerID, not traceID, so it shouldn't cause confusion with the old traceID concept (which is going away anyway in HTRACE-209).

> Rename ProcessId to TracerId
> ----------------------------
>
>                 Key: HTRACE-217
>                 URL: https://issues.apache.org/jira/browse/HTRACE-217
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-217.001.patch, HTRACE-217.002.patch
>
>
> We should rename ProcessId to TracerId.  "ProcessId" is a confusing term since it could also refer to the number which the OS assigns to the process.  Plus, HTrace's concept of ProcessId also includes things like IP address.  Calling it "TracerId" makes more sense.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)