You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/08 04:11:23 UTC

[GitHub] [iceberg] openinx commented on a change in pull request #2778: Core: Fix JdbcCatalog CATALOG_TABLE_NAME to lowercase

openinx commented on a change in pull request #2778:
URL: https://github.com/apache/iceberg/pull/2778#discussion_r665855884



##########
File path: core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java
##########
@@ -27,7 +27,7 @@
 import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
 
 final class JdbcUtil {
-  protected static final String CATALOG_TABLE_NAME = "ICEBERG_TABLES";
+  protected static final String CATALOG_TABLE_NAME = "iceberg_tables";

Review comment:
       What's the specific reason that we need to change it to lower case  ?  Just want to align with the other table names ?  (I read the context from https://github.com/apache/iceberg/issues/2744 but still did not get the point).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org