You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 08:30:53 UTC
[GitHub] [flink] lirui-apache commented on a change in pull request #10922:
[FLINK-11899][parquet][table-runtime] Introduce ParquetColumnarRowSplitReader
lirui-apache commented on a change in pull request #10922: [FLINK-11899][parquet][table-runtime] Introduce ParquetColumnarRowSplitReader
URL: https://github.com/apache/flink/pull/10922#discussion_r385563692
##########
File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/dataformat/vector/heap/AbstractHeapVector.java
##########
@@ -56,11 +67,31 @@ public void reset() {
noNulls = true;
}
+ @Override
public void setNullAt(int i) {
+ if (i >= isNull.length) {
+ throw new RuntimeException();
+ }
isNull[i] = true;
noNulls = false;
}
+ @Override
+ public void setNulls(int i, int count) {
+ for (int j = 0; j < count; j++) {
+ isNull[i + j] = true;
Review comment:
call `setNullAt `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services