You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <ja...@cs.toronto.edu> on 2005/11/28 19:40:20 UTC
Re: svn commit: r17544 - trunk/subversion/libsvn_fs_base
On 11/28/05, maxb@tigris.org <ma...@tigris.org> wrote:
> Log:
> Followup to r17496, r17501.
> Kill more APR-0.9.4-and-earlier compatibility code.
> [...]
> -/* Ensure compatibility with older APR 0.9.5 snapshots which don't
> - * support the APR_LARGEFILE flag. */
> -#ifndef APR_LARGEFILE
> -#define APR_LARGEFILE (0)
> -#endif
> -
Max,
According to the comment above, it looks like this compatibility code
is necessary for development snapshots of 0.9.5, which (I assume)
shipped with some versions of Apache 2.0.x, prior to the official
0.9.5 release. Your log message, on the other hand, states that you're
removing 0.9.4-and-earlier compatibility code. Which is correct?
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
Re: svn commit: r17544 - trunk/subversion/libsvn_fs_base
Posted by Max Bowsher <ma...@ukf.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David James wrote:
> On 11/28/05, maxb@tigris.org <ma...@tigris.org> wrote:
>
>>Log:
>>Followup to r17496, r17501.
>>Kill more APR-0.9.4-and-earlier compatibility code.
>>[...]
>>-/* Ensure compatibility with older APR 0.9.5 snapshots which don't
>>- * support the APR_LARGEFILE flag. */
>>-#ifndef APR_LARGEFILE
>>-#define APR_LARGEFILE (0)
>>-#endif
>>-
>
> Max,
>
> According to the comment above, it looks like this compatibility code
> is necessary for development snapshots of 0.9.5, which (I assume)
> shipped with some versions of Apache 2.0.x, prior to the official
> 0.9.5 release. Your log message, on the other hand, states that you're
> removing 0.9.4-and-earlier compatibility code. Which is correct?
Hmm, yes, I could have been clearer with my log message.
Propedited to read:
Kill more APR pre-0.9.5 compatibility code.
And, yes, I am speaking about APR 0.9.5 *final* here, which does mean
that our configury now needs to be fixed up to reject 0.9.5-dev
snapshots, whilst accepting 0.9.5-release.
This is also true of r17496 and r17501.
Max.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Cygwin)
iD8DBQFDi23ofFNSmcDyxYARAhkNAJ442WAHrqWrkQWVTudrXP7nSai0IgCeOewC
Bpg1U5HtO1yP0qwY0ZFVOvY=
=lO36
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org