You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by an...@apache.org on 2016/06/08 09:38:23 UTC
cordova-plugin-whitelist git commit: CB-113 android: Does not pass
sonarqube scan
Repository: cordova-plugin-whitelist
Updated Branches:
refs/heads/master c10338df8 -> c2c007237
CB-113 android: Does not pass sonarqube scan
The problem is "Correctness - Suspicious reference comparison of Boolean values",
which sonarqube considers major.
This closes #20
Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-whitelist/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-whitelist/commit/c2c00723
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-whitelist/tree/c2c00723
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-whitelist/diff/c2c00723
Branch: refs/heads/master
Commit: c2c0072378193710238d1fab1f12013b9fd359bb
Parents: c10338d
Author: Rob Close <ro...@sap.com>
Authored: Tue Jun 7 15:56:18 2016 -0400
Committer: Vladimir Kotikov <ko...@gmail.com>
Committed: Wed Jun 8 12:38:02 2016 +0300
----------------------------------------------------------------------
src/android/WhitelistPlugin.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-plugin-whitelist/blob/c2c00723/src/android/WhitelistPlugin.java
----------------------------------------------------------------------
diff --git a/src/android/WhitelistPlugin.java b/src/android/WhitelistPlugin.java
index 4e4f57e..2396568 100644
--- a/src/android/WhitelistPlugin.java
+++ b/src/android/WhitelistPlugin.java
@@ -118,7 +118,7 @@ public class WhitelistPlugin extends CordovaPlugin {
@Override
public Boolean shouldAllowRequest(String url) {
- if (Boolean.TRUE == shouldAllowNavigation(url)) {
+ if (shouldAllowNavigation(url)) {
return true;
}
if (allowedRequests.isUrlWhiteListed(url)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org