You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:42:27 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #10979: fix: changed disabled rules in datasets module
kkucharc opened a new pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979
### SUMMARY
Enabled pylint checks in `api.py`:
- refactored return statements in `put` method and enabled `too-many-return-statements` rule,
- removed disabled `arguments-differ` in `put()` and `delete()` methods since API matches.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979#issuecomment-696261560
Just hit retry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett merged pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
willbarrett merged pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979#issuecomment-696242098
@willbarrett Can you take a look? Cypress test timeouted in one case unfortunately, but saw this isn't connected with changes. Is it possible to retry this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kkucharc commented on pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
kkucharc commented on pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979#issuecomment-696242098
@willbarrett Can you take a look? Cypress test timeouted in one case unfortunately, but saw this isn't connected with changes. Is it possible to retry this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #10979: fix: changed disabled rules in datasets module
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10979:
URL: https://github.com/apache/incubator-superset/pull/10979#issuecomment-696261560
Just hit retry
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org