You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/08/28 15:32:52 UTC

[GitHub] flink pull request #4611: [FLINK-7543] [REST] Simplify handler access to pat...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/4611

    [FLINK-7543] [REST] Simplify handler access to path/query parameters

    ## What is the purpose of the change
    
    This PR simplifies the access to path/query parameters by directly returning the value contained in the parameter instead of the parameter itself.
    
    
    ## Brief change log
    
    * make all path parameters mandatory
    * simplify access in `HandlerRequest`
    * simplify test code in `RestEndpointITCase`
    
    
    ## Verifying this change
    
    This change is already covered by existing tests, such as `RestEndpointITCase`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 7544

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4611
    
----
commit dcce0b7631bf65ea66dbe0d64b368c7143815f9e
Author: zentol <ch...@apache.org>
Date:   2017-08-28T14:46:04Z

    [FLINK-7544] [REST] Make all path parameters mandatory

commit 42486981c4310076a99a3cb6983131c2ae14725a
Author: zentol <ch...@apache.org>
Date:   2017-08-28T15:26:01Z

    [FLINK-7543] [REST] Simplify handler access to path/query parameters

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4611: [FLINK-7543] [REST] Simplify handler access to path/query...

Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:

    https://github.com/apache/flink/pull/4611
  
    Changes LGTM @zentol ! 
    
    When Travis gives a green light, feel free to merge!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4611: [FLINK-7543] [REST] Simplify handler access to pat...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4611


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---