You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/09/02 07:44:36 UTC
[GitHub] [rocketmq] ColinZou opened a new pull request #3311: Fixed starup script runserver.sh runbroker.sh problems for zulu jdk and jdk version >= 9
ColinZou opened a new pull request #3311:
URL: https://github.com/apache/rocketmq/pull/3311
**Make sure set the target branch to `develop`**
## What is the purpose of the change
Fixed startup problems for name node and broker for JDK > 8 and MS ZULU JDK
## Brief changelog
1. Fixed wrong classpath: added paths of jar files under ${BASE_DIR}/lib
2. Removed GC logging for ZULU JDK (TODO: figure out proper cmd arguments for zulu jdk)
3. Removed -Djava.ext.dirs=xxx for ZULU JDK and JDK > 8
## Verifying this change
Just run these commands: bin/mqnamesrv and bin/mqbroker. Or you can print JAVA_OPT before the last line "$JAVA ${JAVA_OPT} $@" for more investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Jason918 commented on pull request #3311: Fixed starup script runserver.sh runbroker.sh problems for zulu jdk and jdk version >= 9
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #3311:
URL: https://github.com/apache/rocketmq/pull/3311#issuecomment-935323060
Since there is no issue related to this pr, I think it's better you can describe more details about "startup problem" with detail logs or behaviors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] yuz10 closed pull request #3311: Fixed starup script runserver.sh runbroker.sh problems for zulu jdk and jdk version >= 9
Posted by GitBox <gi...@apache.org>.
yuz10 closed pull request #3311:
URL: https://github.com/apache/rocketmq/pull/3311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] Jason918 commented on a change in pull request #3311: Fixed starup script runserver.sh runbroker.sh problems for zulu jdk and jdk version >= 9
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #3311:
URL: https://github.com/apache/rocketmq/pull/3311#discussion_r722847560
##########
File path: distribution/bin/runbroker.sh
##########
@@ -66,25 +73,44 @@ choose_gc_log_directory
JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g"
JAVA_OPT="${JAVA_OPT} -XX:+UseG1GC -XX:G1HeapRegionSize=16m -XX:G1ReservePercent=25 -XX:InitiatingHeapOccupancyPercent=30 -XX:SoftRefLRUPolicyMSPerMB=0"
-JAVA_OPT="${JAVA_OPT} -verbose:gc -Xloggc:${GC_LOG_DIR}/rmq_broker_gc_%p_%t.log -XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintGCApplicationStoppedTime -XX:+PrintAdaptiveSizePolicy"
-JAVA_OPT="${JAVA_OPT} -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5 -XX:GCLogFileSize=30m"
+
+ZULU_JDK_CHECK=$($JAVA -version 2>&1 | grep -i zulu | wc -l)
+if [ $ZULU_JDK_CHECK -eq 0 ]; then
Review comment:
There's no gc options in zulu JDK at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org