[GitHub] [helix] xyuanlu commented on a diff in pull request #2495: Add recursive persist listener API in ZkClient and test native ZK

["xyuanlu (via GitHub)" <gi...@apache.org>]

xyuanlu commented on code in PR #2495:
URL: https://github.com/apache/helix/pull/2495#discussion_r1200790665


##########
zookeeper-api/src/test/java/org/apache/helix/zookeeper/zkclient/TestZkClientPersistWatcher.java:
##########
@@ -108,6 +110,47 @@ public void handleChildChange(String parentPath, List<String> currentChilds)
     zkClient.close();
   }
 
+  @Test(dependsOnMethods = "testZkClientChildChange")
+  void testZkClientPersistRecursiveChange() throws Exception {

Review Comment:
   TFTR！ Yes this was the plan. Right now it is a dummy test since no impl is add in zkMetaClient right now. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org