[GitHub] [arrow] alamb edited a comment on pull request #9380: ARROW-11444: [Rust][DataFusion] Accept slices as parameters

[GitBox <gi...@apache.org>]

alamb edited a comment on pull request #9380:
URL: https://github.com/apache/arrow/pull/9380#issuecomment-772781707


   ~I merged this PR into master and re-ran the tests locally. Everything is looking fine. 👍  merging it in~
   
   FYI @jorgecarleitao and @andygrove 
   
   Update: clippy now fails locally (probably due to code introduced as part of https://github.com/apache/arrow/pull/9364) -- can you please rebase this @Dandandan ?
   
   ```
   error: useless use of `vec!`
      --> datafusion/src/sql/planner.rs:481:25
       |
   481 |                         &vec![having_expr.clone()],
       |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[having_expr.clone()]`
       |
       = note: `-D clippy::useless-vec` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   
   error: useless use of `vec!`
      --> datafusion/src/sql/planner.rs:602:17
       |
   602 |                 &vec![having_expr_post_aggr.clone()],
       |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[having_expr_post_aggr.clone()]`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org