You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2025/10/19 02:42:55 UTC
[I] infra: change CI to only require approval for first-time contributors [iceberg-python]
kevinjqliu opened a new issue, #2633:
URL: https://github.com/apache/iceberg-python/issues/2633
### Apache Iceberg version
None
### Please describe the bug 🐞
Currently all PRs require approval before running CI. @geruh mentioned that in `apache/iceberg` repo, this is not the case.
Looking into [github's documentation](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-github-actions-settings-for-a-repository#controlling-changes-from-forks-to-workflows-in-public-repositories), there's a setting to change this behavior
* **Require approval for first-time contributors who are new to GitHub.** Only users who are both new on GitHub and who have never had a commit or pull request merged into this repository will require approval to run workflows.
* **Require approval for first-time contributors.** Only users who have never had a commit or pull request merged into this repository will require approval to run workflows.
* **Require approval for all external contributors** All users that are not a member or owner of this repository and not a member of the organization will require approval to run workflows.
Seems like `apache/iceberg-python` is currently set to "Require approval for all external contributors", I think it might be a good idea to change it to "Require approval for first-time contributors"
Happy to bring this up in the devlist :)
PS I dont see this setting in my view of https://github.com/apache/iceberg-python/settings, maybe we need to get apache infra to change it
### Willingness to contribute
- [ ] I can contribute a fix for this bug independently
- [ ] I would be willing to contribute a fix for this bug with guidance from the Iceberg community
- [ ] I cannot contribute a fix for this bug at this time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed issue #2633: infra: change CI to only require approval for first-time contributors
URL: https://github.com/apache/iceberg-python/issues/2633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3422720687
Thanks for the pointer. I found the past devlist discussion: ["[Discuss] Change iceberg-python and iceberg-go CI Settings to only require approval for first time contributors" ](https://lists.apache.org/thread/7m0pnml7kr52ky665ybw75ospzjg8jr9)
Honah raised an issue with apache infra, https://issues.apache.org/jira/browse/INFRA-25457 and it was marked as resolved.
@Fokko are you able to double check this setting? Should be in https://github.com/apache/iceberg-python/settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3421106589
Thanks for bringing this up @kevinjqliu, I also noticed this. Please check for earlier discussions on the dev-list, because I'm pretty sure that there was consensus to only require a check the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3443981009
Apache infra confirmed that change was made to these repos:
* https://github.com/apache/iceberg
* https://github.com/apache/iceberg-python
* https://github.com/apache/iceberg-rust
* https://github.com/apache/iceberg-go
* https://github.com/apache/iceberg-cpp
iceberg-rust and iceberg-cpp already had this setting
I see this is already working for https://github.com/apache/iceberg/pull/14414
lets see another PR from iceberg-python or iceberg-go to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "Aniketsy (via GitHub)" <gi...@apache.org>.
Aniketsy commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3422867811
I’d love to work on this if it hasn’t been resolved yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3444354883
sent out a devlist thread https://lists.apache.org/thread/6x6os4q37vvzmpcq8ry5dcvvd1knjwwn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3444187552
i see it works for https://github.com/apache/iceberg-python/pull/2660
great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] infra: change CI to only require approval for first-time contributors [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #2633:
URL: https://github.com/apache/iceberg-python/issues/2633#issuecomment-3433454780
Thanks for the offer @Aniketsy, the next step is to reach out to apache infra to modify the settings.
I created https://issues.apache.org/jira/browse/INFRA-27351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org