[GitHub] [beam] iemejia commented on a change in pull request #14171: [BEAM-11913] Add support for Hadoop configuration on ParquetIO

[GitBox <gi...@apache.org>]

iemejia commented on a change in pull request #14171:
URL: https://github.com/apache/beam/pull/14171#discussion_r590084936



##########
File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##########
@@ -641,11 +661,14 @@ public ReadFiles withProjection(Schema projectionSchema, Schema encoderSchema) {
 
     /** Specify Hadoop configuration for ParquetReader. */
     public ReadFiles withConfiguration(Map<String, String> configuration) {
+      checkArgument(configuration != null, "configuration can not be null");
       return toBuilder().setConfiguration(SerializableConfiguration.fromMap(configuration)).build();
     }
 
-    public ReadFiles withConfiguration(SerializableConfiguration configuration) {

Review comment:
       This change is to fix the API that was accidentally exposed as part of [BEAM-11861](https://issues.apache.org/jira/browse/BEAM-11861) #14078




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org