[jira] [Comment Edited] (FLINK-15058) Log required config keys if TaskManager memory configuration is invalid

["Xintong Song (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-15058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988332#comment-16988332 ] 

Xintong Song edited comment on FLINK-15058 at 12/5/19 12:38 AM:
----------------------------------------------------------------

Thanks for bring this up, [~gjy].

I believe this behavior is by the design of FLIP-49, that we require either of the three config options or pair of config options being explicitly configured. So we do not have default values for these mentioned config options.

For out of box experience, we have set total process memory size in the default 'flink-conf.yaml'.

But I think it's discussable that whether we want to apply a default value for total process memory size, if neither of the three is configured. [~zhuzh] and [~Aihua] also encountered yesterday during testing that the recent flink 1.10 snapshot distribution failed with a previous setup where task manager memory is not configured in "flink-conf.yaml".

WDYT?

cc [~sewen] [~trohrmann] [~azagrebin]


was (Author: xintongsong):
Thanks for bring this up, [~gjy].

I believe this behavior is by the design of FLIP-49, that we require either of the three config options or pair of config options being explicitly configured. So we do not have default values for these mentioned config options.

For out of box experience, we have set total process memory size in the default 'flink-conf.yaml'.

But I think it's discussable that whether we want to apply a default value for total process memory size, if neither the three is configured. [~zhuzh] and [~Aihua] also encountered yesterday during testing that the recent flink 1.10 snapshot distribution failed with a previous setup where task manager memory is not configured in "flink-conf.yaml".

WDYT?

cc [~sewen] [~trohrmann] [~azagrebin]

> Log required config keys if TaskManager memory configuration is invalid
> -----------------------------------------------------------------------
>
>                 Key: FLINK-15058
>                 URL: https://issues.apache.org/jira/browse/FLINK-15058
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Coordination
>    Affects Versions: 1.10.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Major
>             Fix For: 1.10.0
>
>
> Currently the error message is
> {noformat}
> Either Task Heap Memory size and Managed Memory size, or Total Flink Memory size, or Total Process Memory size need to be configured explicitly
> {noformat}
> However, it would be good to immediately see which config keys are expected to be configured.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)