You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/19 16:30:20 UTC

[GitHub] [iceberg] jackye1995 commented on pull request #6474: Make it explicit that metrics reporter is required

jackye1995 commented on PR #6474:
URL: https://github.com/apache/iceberg/pull/6474#issuecomment-1397260633

   > We keep asking "can this be null" question in PR reviews
   
   Yes this is the consequence of different styles of the projects. I like Trino's approach of checking null at every constructor and also use Optional as much as possible. For Iceberg, it would be ideal if nullability is at least indicated in documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org